826881 - Image loading - progress indicator keeps spinning forever

Status: RESOLVED WORKSFORME

(Core :: DOM: Core & HTML, defect)

Description

[Dmitry Semenov]

User Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10_8_2) AppleWebKit/537.11 (KHTML, like Gecko) Chrome/23.0.1271.101 Safari/537.11

Steps to reproduce:

Create image dynamically and append it DOM directly on load event. 
It happens for me not with every image. Image should be large, or server with it should be slow to reporduce the issue.

// jQuery, in document.ready:
var url = "http://upload.wikimedia.org/wikipedia/commons/thumb/e/ec/Mona_Lisa%2C_by_Leonardo_da_Vinci%2C_from_C2RMF_retouched.jpg/687px-Mona_Lisa%2C_by_Leonardo_da_Vinci%2C_from_C2RMF_retouched.jpg";
var img = $('<img/>').on('load error', function() {
         // this part causes problem, if you delay appending using timeout issue gets solved
         $('div').append(img);
}).attr('src', url);



I localized the issue, and created jsfiddle where you can test this: http://jsfiddle.net/XX9FK/

Also, I recorded short screencast of this bug: http://www.youtube.com/watch?v=3bAJF-_6rY0


Actual results:

Progress indicator in tab keeps spinning forever, network panels show nothing.

Comment 1

[Alice0775 White]

Regression window(m-i)
Good:
http://hg.mozilla.org/integration/mozilla-inbound/rev/a27a41c7d7e3
Mozilla/5.0 (Windows NT 6.1; WOW64; rv:19.0) Gecko/19.0 Firefox/19.0 ID:20121011091302
Bad:
http://hg.mozilla.org/integration/mozilla-inbound/rev/c58bfc3f6b48
Mozilla/5.0 (Windows NT 6.1; WOW64; rv:19.0) Gecko/19.0 Firefox/19.0 ID:20121011100002
Pushlog:
http://hg.mozilla.org/integration/mozilla-inbound/pushloghtml?fromchange=a27a41c7d7e3&tochange=c58bfc3f6b48
Regressed by:
5b26e3ffe80d	Kyle Huey — Bug 791571: Keep track of whether or not an <img> is blocking onload to handle insertion/removal from the document. r=bz

Comment 2

[Alex Keybl [:akeybl]]

Why is this issue critical?

Comment 3

[Tom Goetz]

Having the same problem, it breaks galleria script in many cases, which is very popular. I tried setTimeout trick, but it doesn't seem to work.

Comment 4

[Alex Keybl [:akeybl]]

(In reply to Tom Goetz from comment #3)
> Having the same problem, it breaks galleria script in many cases, which is
> very popular. I tried setTimeout trick, but it doesn't seem to work.

This is a Firefox 17 regression (been out for 1.5 months) that does not impact any major web properties that we're aware of. We would accept a low risk fix, but there's no need to track for upcoming releases.

Comment 5

[Praveen Ponnusamy]

I have run into this problem as well. 

You can reproduce it using this app (just load the app and notice the progress indicator keeps spinning):
http://help.arcgis.com/en/webapi/javascript/arcgis/samples/fl_popup/index.html

Comment 6

[Kyle Huey (Exited; not receiving bugmail, old account, do not use)]

I don't remember which bug, but we fixed this some time in the Firefox 21 cycle.  It WFM on Nightly and Aurora.