826893 - Provider for application session information

Status: RESOLVED FIXED

(Firefox Health Report Graveyard :: Client: Desktop, defect)

Description

[Gregory Szorc [:gps]]

Need to capture per day session counts, time active/inactive, and startup times (main, first paint, session restore).

Comment 1

[Gregory Szorc [:gps]]

Attachment: Provider for application sessions, v1

There is much room for improvement in the reported values. See comments.

Comment 2

[Richard Newman [:rnewman]]

Comment on attachment 698400 [details] [diff] [review]
Provider for application sessions, v1

Review of attachment 698400 [details] [diff] [review]:
-----------------------------------------------------------------

Your call if you want to spend the time to switch to tick counting rather than calculating intervals. Apologies for the bugs I missed!

::: services/healthreport/providers.jsm
@@ +328,5 @@
> +
> +  name: "current",
> +  version: 1,
> +
> +  FIELDS: [

LAST_NUMERIC_FIELDS

@@ +369,5 @@
> +
> +  name: "previous",
> +  version: 1,
> +
> +  FIELDS: [

DAILY_DISCRETE_NUMERIC_FIELDS

@@ +468,5 @@
> +      if (!(field in si)) {
> +        continue;
> +      }
> +
> +      let value = si[field] - si.process;

Ooh, obscure. Politely note somewhere that "si.process" is the timestamp of the "process" event, which implicitly means the start of this session?

@@ +515,5 @@
> +   */
> +  recordBrowserActivity: function (active) {
> +    // There is potential for clock skew to result in incorrect measurements
> +    // here. We should consider incrementing activeTime by the observer firing
> +    // interval.

Yeah, seems smarter to count ticks then multiply than to calculate intervals.

Comment 3

[Gregory Szorc [:gps]]

https://hg.mozilla.org/services/services-central/rev/36592fb313ad

Will need follow-ups to refactor this one.

Comment 4

[Gregory Szorc [:gps]]

https://hg.mozilla.org/mozilla-central/rev/36592fb313ad