826935 - ensure app.installState is defined in DOMApplicationRegistry.loadCurrentRegistry()

Status: RESOLVED FIXED

(Core Graveyard :: DOM: Apps, defect)

Description

[Myk Melez [:myk] [@mykmelez]]

If an app record in webapps.json has no installState property, then DOMApplicationRegistry.loadCurrentRegistry() doesn't define it when reading webapps.json into its DOMApplicationRegistry.webapps object (unlike WebappsApplication.init(), which sets it to "installed").

That causes problems when DOMApplicationRegistry.startDownload() is called to update an installed app with no installState, because the isUpdate local variable will be set to false instead of true, and the installState will eventually wind up being "pending" instead of "updating" when this code is evaluated near the end of the function:

            if (app.installState == "pending") {
              // We restarted a failed download, apply it automatically.
              DOMApplicationRegistry.applyDownload(aManifestURL);
            }

But the download isn't failed; and it shouldn't be applied automatically.

The Gaia build scripts don't set installState, so you'll run into this problem if you start B2G for the first time with a new Gaia profile, check for a packaged app update, and find one; which is exactly what we hope will happen to users who get devices with preloaded packaged app stubs that trigger update checks.

Perhaps the build scripts should set this property. But DOMApplicationRegistry shouldn't depend on it being set, just as WebappsApplication doesn't.  Ideally, we also wouldn't have two different types of app object with completely different initialization routines, but fixing that is risky.  The minimal fix here is for DOMApplicationRegistry to set installState to "installed" if it's undefined.

Comment 1

[Myk Melez [:myk] [@mykmelez]]

Attachment: patch v1: ensures app.installState is defined

Comment 2

[Jason Smith [:jsmith]]

Comment on attachment 698188 [details] [diff] [review]
patch v1: ensures app.installState is defined

I think Fabrice is out. And backup reviewer #2 ferjm is out too. So backup reviewer #3 is Jonas.

Comment 3

[Phil Ringnalda (:philor)]

https://hg.mozilla.org/mozilla-central/rev/3e5ec076ceb2

Comment 4

[Myk Melez [:myk] [@mykmelez]]

Comment on attachment 698188 [details] [diff] [review]
patch v1: ensures app.installState is defined

https://tbpl.mozilla.org/?tree=Mozilla-Inbound&rev=3e5ec076ceb2

Comment 5

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-b2g18/rev/079b8e07e73d