Closed Bug 826999 Opened 7 years ago Closed 7 years ago

Add @2x arrow icons for the Downloads Panel notifications

Categories

(Firefox :: Downloads Panel, defect, P2)

x86
macOS
defect

Tracking

()

RESOLVED FIXED
Firefox 21
Tracking Status
firefox20 --- fixed

People

(Reporter: Paolo, Assigned: mconley)

References

()

Details

Attachments

(3 files)

+++ This bug was initially created as a clone of Bug #812813 +++

We should add the 2x versions of the notification for OSX.

The 2x notification with the colored arrow is attachment 698042 [details].
Assignee: nobody → mconley
Flags: needinfo?(shorlander)
Summary: Add 256x256 arrow icons for the Downloads Panel notifications → Add @2x arrow icons for the Downloads Panel notifications
We need the 256x256 grey notification arrow.
Bringing this over from bug 812813 where it was posted, but not included in the patch.
Attached patch Patch v1Splinter Review
Comment on attachment 700636 [details] [diff] [review]
Patch v1

Unfortunately, I do not have a high dpi display to test this on.
Attachment #700636 - Flags: review?(mak77)
(In reply to Mike Conley (:mconley) from comment #5)
> Comment on attachment 700636 [details] [diff] [review]
> Patch v1
> 
> Unfortunately, I do not have a high dpi display to test this on.

Looks good on a retina display to me.
Comment on attachment 700636 [details] [diff] [review]
Patch v1

Review of attachment 700636 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good to me.
Attachment #700636 - Flags: review?(mak77) → review+
Comment on attachment 700636 [details] [diff] [review]
Patch v1

[Approval Request Comment]
Bug caused by (feature/regressing bug #): Downloads panel feature
User impact if declined: incomplete ui
Testing completed (on m-c, etc.): m-i (merge pending)
Risk to taking this patch (and alternatives if risky): limited to the feature
String or UUID changes made by this patch: none
Attachment #700636 - Flags: approval-mozilla-aurora?
https://hg.mozilla.org/mozilla-central/rev/9d5aa1109267
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 21
Attachment #700636 - Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
You need to log in before you can comment on or make changes to this bug.