826999 - Add @2x arrow icons for the Downloads Panel notifications

Status: RESOLVED FIXED

(Firefox :: Downloads Panel, defect, P2)

Description

[:Paolo Amadini]

+++ This bug was initially created as a clone of Bug #812813 +++

We should add the 2x versions of the notification for OSX.

The 2x notification with the colored arrow is attachment 698042 [details].

Comment 1

[:Paolo Amadini]

We need the 256x256 grey notification arrow.

Comment 2

[Stephen Horlander [:shorlander]]

Attachment: Download Start Notification @2x

Comment 3

[Mike Conley (:mconley) (:⚙️)]

Attachment: Download Finish Notification @2x

Bringing this over from bug 812813 where it was posted, but not included in the patch.

Comment 4

[Mike Conley (:mconley) (:⚙️)]

Attachment: Patch v1

Comment 5

[Mike Conley (:mconley) (:⚙️)]

Comment on attachment 700636 [details] [diff] [review]
Patch v1

Unfortunately, I do not have a high dpi display to test this on.

Comment 6

[Stephen Horlander [:shorlander]]

(In reply to Mike Conley (:mconley) from comment #5)
> Comment on attachment 700636 [details] [diff] [review]
> Patch v1
> 
> Unfortunately, I do not have a high dpi display to test this on.

Looks good on a retina display to me.

Comment 7

[Stephen Horlander [:shorlander]]

Comment on attachment 700636 [details] [diff] [review]
Patch v1

Review of attachment 700636 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good to me.

Comment 8

[Mike Conley (:mconley) (:⚙️)]

Thanks! Landed on mozilla-inbound as https://hg.mozilla.org/integration/mozilla-inbound/rev/9d5aa1109267

Comment 9

[Marco Bonardo [:mak] (Away Apr 25 - May 5)]

Comment on attachment 700636 [details] [diff] [review]
Patch v1

[Approval Request Comment]
Bug caused by (feature/regressing bug #): Downloads panel feature
User impact if declined: incomplete ui
Testing completed (on m-c, etc.): m-i (merge pending)
Risk to taking this patch (and alternatives if risky): limited to the feature
String or UUID changes made by this patch: none

Comment 10

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/9d5aa1109267

Comment 11

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/9d5aa1109267

Comment 12

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/9d5aa1109267

Comment 13

[Marco Bonardo [:mak] (Away Apr 25 - May 5)]

https://hg.mozilla.org/releases/mozilla-aurora/rev/43e7be276fb7