Closed
Bug 826999
Opened 12 years ago
Closed 12 years ago
Add @2x arrow icons for the Downloads Panel notifications
Categories
(Firefox :: Downloads Panel, defect, P2)
Tracking
()
RESOLVED
FIXED
Firefox 21
| Tracking | Status | |
|---|---|---|
| firefox20 | --- | fixed |
People
(Reporter: Paolo, Assigned: mconley)
References
()
Details
Attachments
(3 files)
|
19.05 KB,
image/png
|
Details | |
|
9.01 KB,
image/png
|
Details | |
|
40.00 KB,
patch
|
shorlander
:
review+
Gavin
:
approval-mozilla-aurora+
|
Details | Diff | Splinter Review |
Download Start Notification @2x
+++ This bug was initially created as a clone of Bug #812813 +++
We should add the 2x versions of the notification for OSX.
The 2x notification with the colored arrow is attachment 698042 [details].
|
||
Updated•12 years ago
|
Assignee: nobody → mconley
Flags: needinfo?(shorlander)
Summary: Add 256x256 arrow icons for the Downloads Panel notifications → Add @2x arrow icons for the Downloads Panel notifications
|
Reporter | |
Comment 1•12 years ago
|
||
We need the 256x256 grey notification arrow.
|
||
Comment 2•12 years ago
|
||
Flags: needinfo?(shorlander)
|
Assignee | |
Comment 3•12 years ago
|
||
Bringing this over from bug 812813 where it was posted, but not included in the patch.
|
|
Assignee | |
Comment 4•12 years ago
|
||
|
|
Assignee | |
Comment 5•12 years ago
|
||
Comment on attachment 700636 [details] [diff] [review]
Patch v1
Unfortunately, I do not have a high dpi display to test this on.
Attachment #700636 -
Flags: review?(mak77)
|
|
||
Comment 6•12 years ago
|
||
(In reply to Mike Conley (:mconley) from comment #5)
> Comment on attachment 700636 [details] [diff] [review]
> Patch v1
>
> Unfortunately, I do not have a high dpi display to test this on.
Looks good on a retina display to me.
|
|
||
Comment 7•12 years ago
|
||
Comment on attachment 700636 [details] [diff] [review]
Patch v1
Review of attachment 700636 [details] [diff] [review]:
-----------------------------------------------------------------
Looks good to me.
Attachment #700636 -
Flags: review?(mak77) → review+
|
|
Assignee | |
Comment 8•12 years ago
|
||
Thanks! Landed on mozilla-inbound as https://hg.mozilla.org/integration/mozilla-inbound/rev/9d5aa1109267
|
|
||
Comment 9•12 years ago
|
||
Comment on attachment 700636 [details] [diff] [review]
Patch v1
[Approval Request Comment]
Bug caused by (feature/regressing bug #): Downloads panel feature
User impact if declined: incomplete ui
Testing completed (on m-c, etc.): m-i (merge pending)
Risk to taking this patch (and alternatives if risky): limited to the feature
String or UUID changes made by this patch: none
Attachment #700636 -
Flags: approval-mozilla-aurora?
|
||
Comment 10•12 years ago
|
||
Status: NEW → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 21
|
|
||
Comment 11•12 years ago
|
||
|
|
||
Comment 12•12 years ago
|
||
|
||
Updated•12 years ago
|
Attachment #700636 -
Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
|
|
||
Comment 13•12 years ago
|
||
status-firefox20:
--- → fixed
You need to log in
before you can comment on or make changes to this bug.
Description
•