827086 - Compilation error "a space is required between consecutive right angle brackets (use '> >')" in dom/UndoManager.h

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, defect)

Description

[Simon Montagu :smontagu]

Building mozilla-central today I get the following error:

In file included from /home/smontagu/mozwork/hgtree/mozilla/obj-x86_64-unknown-linux-gnu/dom/bindings/ElementBinding.cpp:23:
../../dist/include/mozilla/dom/UndoManager.h:41:65: error: a space is required between consecutive right angle brackets (use '> >')
            Nullable<nsTArray<nsRefPtr<nsIUndoManagerTransaction>>>& aItems,
                                                                ^~
                                                                > > 
1 error generated.

Comment 1

[Simon Montagu :smontagu]

Attachment: Add the spaces

Adding the spaces like the man said fixes it for me.

Comment 2

[Simon Montagu :smontagu]

Attachment: Add the spaces

Added a couple more places

Comment 3

[:Ms2ger (he/him; ⌚ UTC+1/+2)]

Comment on attachment 698403 [details] [diff] [review]
Add the spaces

Review of attachment 698403 [details] [diff] [review]:
-----------------------------------------------------------------

r=me, though I'd prefer symmetric spaces (as in

Nullable< nsTArray< nsRefPtr<nsIUndoManagerTransaction> > >

).

Comment 4

[Olli Pettay [:smaug][[e-mail]]]

That is not the common coding style.
It should be
Nullable<nsTArray<nsRefPtr<nsIUndoManagerTransaction> > >

Comment 5

[Simon Montagu :smontagu]

https://hg.mozilla.org/integration/mozilla-inbound/rev/ada416951818

Comment 6

[Phil Ringnalda (:philor)]

https://hg.mozilla.org/mozilla-central/rev/ada416951818