827102 - Front end changes needed due to new UndoManager in nsITransactionManager (Bug 617532)

Status: RESOLVED FIXED

(SeaMonkey :: General, defect)

Description

[Philip Chee]

http://tinderbox.mozilla.org/showlog.cgi?log=SeaMonkey/1357471491.1357472143.20150.gz#err0

/builds/slave/comm-cen-trunk-lnx64/build/objdir/_virtualenv/bin/python /builds/slave/comm-cen-trunk-lnx64/build/objdir/mozilla/dist/sdk/bin/xpt.py link _xpidlgen/msgcompose.xpt _xpidlgen/nsIMsgAttachment.xpt _xpidlgen/nsIMsgComposeProgressParams.xpt _xpidlgen/nsIMsgComposeParams.xpt _xpidlgen/nsIMsgComposeService.xpt _xpidlgen/nsIMsgCompose.xpt _xpidlgen/nsIMsgCompFields.xpt _xpidlgen/nsIMsgQuote.xpt _xpidlgen/nsIMsgQuotingOutputStreamListener.xpt _xpidlgen/nsIMsgSendListener.xpt _xpidlgen/nsIMsgSendLaterListener.xpt _xpidlgen/nsIMsgSend.xpt _xpidlgen/nsIMsgSendLater.xpt _xpidlgen/nsIMsgSendReport.xpt _xpidlgen/nsISmtpServer.xpt _xpidlgen/nsISmtpUrl.xpt _xpidlgen/nsISmtpService.xpt _xpidlgen/nsIURLFetcher.xpt _xpidlgen/nsIMsgComposeSecure.xpt _xpidlgen/nsIMsgCompUtils.xpt
../../../../mailnews/base/src/nsMsgCopyService.cpp: In member function ‘nsresult nsMsgCopyService::ClearRequest(nsCopyRequest*, nsresult)’:
../../../../mailnews/base/src/nsMsgCopyService.cpp:208:38: error: no matching function for call to ‘nsITransactionManager::EndBatch()’
../../../mozilla/dist/include/nsITransactionManager.h:66:60: note: candidate is: virtual nsresult nsITransactionManager::EndBatch(bool)
../../../../mailnews/base/src/nsMsgCopyService.cpp: In member function ‘virtual nsresult nsMsgCopyService::CopyMessages(nsIMsgFolder*, nsIArray*, nsIMsgFolder*, bool, nsIMsgCopyServiceListener*, nsIMsgWindow*, bool)’:
../../../../mailnews/base/src/nsMsgCopyService.cpp:528:39: error: no matching function for call to ‘nsITransactionManager::BeginBatch()’
../../../mozilla/dist/include/nsITransactionManager.h:63:60: note: candidate is: virtual nsresult nsITransactionManager::BeginBatch(nsISupports*)

http://hg.mozilla.org/mozilla-central/rev/6e251f2906f5
Bug 617532 (Implement UndoManager) changed the IDL.

I filed MailNews Coire Bug 827100 (Fix bustage due to new UndoManager in nsITransactionManager (Bug 617532)) for the backend changes but we need to fix the front end as well similar to the changes in Firefox:

http://hg.mozilla.org/mozilla-central/rev/6e251f2906f5#l1.1

Comment 1

[[e-mail]]

http://hg.mozilla.org/comm-central/rev/ae2ca7eee9c3
http://hg.mozilla.org/comm-central/rev/35004deee5b1
(Yeah, I messed up the first time. Sorry about that. Thanks Stefan!)