Closed Bug 827178 Opened 7 years ago Closed 3 years ago

Update stage.m.o cron to match recent changes with ffxbld cron

Categories

(SeaMonkey :: Release Engineering, defect)

x86_64
Windows 7
defect
Not set

Tracking

(Not tracked)

RESOLVED INCOMPLETE

People

(Reporter: Callek, Assigned: Callek)

Details

Attachments

(1 file, 1 obsolete file)

Attached patch [productdelivery] v1 (obsolete) — Splinter Review
This is in the productdeliver MoCo svn module so I'm asking for formal review from nick. f? from KaiRo.
Attachment #698480 - Flags: review?(nthomas)
Attachment #698480 - Flags: feedback?(kairo)
Comment on attachment 698480 [details] [diff] [review]
[productdelivery] v1

>Index: files/cron/seabld
>+# Archive a nightly debug build for each platform for QA regression testing, errors sent via cronmail, stdout to log
>+#0 3 * * * (echo; date; nice -n 19 /usr/local/bin/archive-debug-builds.sh) >> $HOME/archive_debug_builds.log
>+# -- .sh script assumes Firefox

Indeed it does. Happy to take a patch which accepts the product as an argument.
 
>+# Keep 30 days of on-change builds
>+@hourly   flock -w 0 /tmp/seamonkey_tinderbox-builds.lock -c 'nice -n 19 /usr/local/bin/cleanup_tinderbox-builds.sh /pub/mozilla.org/seamonkey/tinderbox-builds' || echo Error or cleanup already running, check for problems

This won't work so well. Firefox has builds on two separate NFS partitions and this script handles moving bits around. If you really want 30 days of builds then modify cron.d/cleanup-hourly-builds to remove thunderbird and add a copy of that line to cron/seabld with the new expiry.
 
>+## clean up localized builds when merges change the version, aurora needs to persist for a week for QA signoff

Not true in SeaMonkey's case ?
Attachment #698480 - Flags: review?(nthomas) → review-
Comment on attachment 698480 [details] [diff] [review]
[productdelivery] v1

Review of attachment 698480 [details] [diff] [review]:
-----------------------------------------------------------------

I mostly only looked at the comments, but the basic stuff being done according to those looks good to me. :)

::: files/cron/seabld
@@ +20,5 @@
> +## cleanup dep build logs
> +@daily nice -n 19 find /pub/mozilla.org/seamonkey/tinderbox-builds/*-l10n -type f -mtime +29 -name *txt.gz -exec rm -f {} \;
> +## clean up localized nightly builds older than a few days, to keep disk usage under control but still provide nightly updates
> +0  23 * * * find /pub/mozilla.org/seamonkey/nightly/201? -mindepth 2 -maxdepth 2 -type d -name '*-comm-*-l10n' -mtime +5 -exec rm -rf {} \; && symlinks -d /pub/mozilla.org/seamonkey/nightly > /dev/null
> +## clean up localized builds when merges change the version, aurora needs to persist for a week for QA signoff

As Nick says, we probably don't need that week here - two days should be enough, like on trunk.
Attachment #698480 - Flags: feedback?(kairo) → feedback+
Take 2 (so we can cleanup most things automatically)
Attachment #698480 - Attachment is obsolete: true
Attachment #766495 - Flags: review?(nthomas)
Attachment #766495 - Flags: review?(nthomas) → review+
Comment on attachment 766495 [details] [diff] [review]
[productdelivery] v2

Hm, you should add a cron to clean up /pub/mozilla.org/seamonkey/tinderbox-builds (having removed cleanup_tinderbox-builds.sh since the last patch, and the current cleanup in ftp-staging-rw-server). I don't need to see this again though.
> Hm, you should add a cron to clean up
> /pub/mozilla.org/seamonkey/tinderbox-builds (having removed
> cleanup_tinderbox-builds.sh since the last patch, and the current cleanup in
> ftp-staging-rw-server). I don't need to see this again though.

Callek please check this in or otherwise resolve this bug. Thanks.
Status: NEW → ASSIGNED
Flags: needinfo?(bugspam.Callek)
Not sure the end status on this bug, however we're no longer using any cron on stage.* due to the cloud move of product delivery.
Status: ASSIGNED → RESOLVED
Closed: 3 years ago
Flags: needinfo?(bugspam.Callek)
Resolution: --- → INCOMPLETE
You need to log in before you can comment on or make changes to this bug.