827217 - webgl.can-lose-context-in-foreground=false crashes in desktop Firefox

Status: VERIFIED FIXED

(Core :: Graphics: CanvasWebGL, defect)

Description

[Jesse Ruderman]

Attachment: testcase

1. Create a new profile (mkdir -p ~/px/a; firefox -profile ~/px/a)
2. Set:
     user_pref("webgl.can-lose-context-in-foreground", false);
3. Install https://www.squarefree.com/extensions/domFuzzLite3.xpi
4. Load the testcase

Assertion failure: mRawPtr, at StaticPtr.h:132

Comment 1

[Jesse Ruderman]

Attachment: stack+

Comment 2

[Justin Lebar (not reading bugmail)]

Attachment: Patch, v1

I think this could affect B2G if we ever created a GL context in the main process.

Comment 3

[Justin Lebar (not reading bugmail)]

remote:   https://hg.mozilla.org/integration/mozilla-inbound/rev/88cee54b26e0

Comment 4

[Justin Lebar (not reading bugmail)]

Comment on attachment 698559 [details] [diff] [review]
Patch, v1

[Approval Request Comment]
Bug caused by (feature/regressing bug #): Bug 823610
User impact if declined: Potential crashes in main B2G process
Testing completed (on m-c, etc.): Trivial patch
Risk to taking this patch (and alternatives if risky): Trivial patch
String or UUID changes made by this patch: None

Comment 5

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/88cee54b26e0

Comment 6

[Alex Keybl [:akeybl]]

Comment on attachment 698559 [details] [diff] [review]
Patch, v1

[Triage Comment]
Approving for mozilla-beta 19 and mozilla-b2g18. We wouldn't typically take a change of this nature without significant user impact, but with a week until release and only 2 days of bake time for the regressing bug, it's worth it to take a trivial fix.

Comment 7

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-b2g18/rev/4e5110a9850d

Comment 8

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-beta/rev/6b8f1007e2f8

Comment 9

[Ioana (away)]

Verified as fixed on Firefox 19 Beta 3 - 20130123083802:
Mozilla/5.0 (Windows NT 6.1; rv:19.0) Gecko/20100101 Firefox/19.0
Mozilla/5.0 (X11; Linux i686; rv:19.0) Gecko/20100101 Firefox/19.0
Mozilla/5.0 (Macintosh; Intel Mac OS X 10.8; rv:19.0) Gecko/20100101 Firefox/19.0

There are no recent crashes in Socorro either:
https://crash-stats.mozilla.com/report/list?product=Firefox&query_search=signature&query_type=contains&query=mozilla%3A%3Adom%3A%3Aipc%3A%3ACurrentProcessIsForeground%28%29&reason_type=contains&date=01%2F24%2F2013%2015%3A32%3A47&range_value=4&range_unit=weeks&hang_type=any&process_type=any&do_query=1&signature=mozilla%3A%3Adom%3A%3Aipc%3A%3ACurrentProcessIsForeground%28%29

Comment 10

[Ioana (away)]

Verified as fixed on Friefox 20 Beta 1 (20130220104816):
Mozilla/5.0 (Windows NT 6.1; rv:20.0) Gecko/20100101 Firefox/20.0
Mozilla/5.0 (X11; Linux i686; rv:20.0) Gecko/20100101 Firefox/20.0
Mozilla/5.0 (Macintosh; Intel Mac OS X 10.8; rv:20.0) Gecko/20100101 Firefox/20.0

There are no new crashes in Socorro either.

Comment 11

[Ioana (away)]

No crashes in Socorro for Firefox 20, 21, and 22, post-fix.