827226 - Android signing should exit if downloads fail

Status: RESOLVED FIXED

(Release Engineering :: Release Automation, defect)

Description

[Nick Thomas [:nthomas] (UTC+12)]

From 18.0 build1 signing:
15:05:30     INFO - mkdir: /home/cltsign/signing-work/release/unsigned/android/multi
15:05:30     INFO - Downloading http://ftp.mozilla.org/pub/mozilla.org/mobile/candidates/18.0-candidates/build1/unsigned/android/multi/fennec-18.0.multi.android-arm.apk to /home/cltsign/signing-work/release/unsigned/android/multi/gec
ko.ap_
15:05:30  WARNING - Try 1: Server returned status 404 HTTP Error 404: Not Found for http://ftp.mozilla.org/pub/mozilla.org/mobile/candidates/18.0-candidates/build1/unsigned/android/multi/fennec-18.0.multi.android-arm.apk
15:05:30     INFO - Sleeping 20 seconds...
15:05:50  WARNING - Try 2: Server returned status 404 HTTP Error 404: Not Found for http://ftp.mozilla.org/pub/mozilla.org/mobile/candidates/18.0-candidates/build1/unsigned/android/multi/fennec-18.0.multi.android-arm.apk
15:05:50     INFO - Sleeping 40 seconds...
15:06:30  WARNING - Try 3: Server returned status 404 HTTP Error 404: Not Found for http://ftp.mozilla.org/pub/mozilla.org/mobile/candidates/18.0-candidates/build1/unsigned/android/multi/fennec-18.0.multi.android-arm.apk
15:06:30     INFO - Sleeping 60 seconds...
15:07:30  WARNING - Try 4: Server returned status 404 HTTP Error 404: Not Found for http://ftp.mozilla.org/pub/mozilla.org/mobile/candidates/18.0-candidates/build1/unsigned/android/multi/fennec-18.0.multi.android-arm.apk
15:07:30     INFO - Sleeping 80 seconds...
15:08:50  WARNING - Try 5: Server returned status 404 HTTP Error 404: Not Found for http://ftp.mozilla.org/pub/mozilla.org/mobile/candidates/18.0-candidates/build1/unsigned/android/multi/fennec-18.0.multi.android-arm.apk
15:08:50     INFO - Sleeping 100 seconds...
15:10:30    ERROR - Try 6: Server returned status 404 HTTP Error 404: Not Found for http://ftp.mozilla.org/pub/mozilla.org/mobile/candidates/18.0-candidates/build1/unsigned/android/multi/fennec-18.0.multi.android-arm.apk
15:10:30    ERROR - Unable to download android:multi unsigned apk!
15:10:30     INFO - mkdir: /home/cltsign/signing-work/release/unsigned/android-armv6/en-US
15:10:30     INFO - Downloading http://ftp.mozilla.org/pub/mozilla.org/mobile/candidates/18.0-candidates/build1/unsigned/android-armv6/en-US/fennec-18.0.en-US.android-arm-armv6.apk to /home/cltsign/signing-work/release/unsigned/andro
id-armv6/en-US/gecko.ap_
15:10:31     INFO - mkdir: /home/cltsign/signing-work/release/unsigned/android-armv6/multi
15:10:31     INFO - Downloading http://ftp.mozilla.org/pub/mozilla.org/mobile/candidates/18.0-candidates/build1/unsigned/android-armv6/multi/fennec-18.0.multi.android-arm-armv6.apk to /home/cltsign/signing-work/release/unsigned/andro
id-armv6/multi/gecko.ap_
15:10:31  WARNING - Try 1: Server returned status 404 HTTP Error 404: Not Found for http://ftp.mozilla.org/pub/mozilla.org/mobile/candidates/18.0-candidates/build1/unsigned/android-armv6/multi/fennec-18.0.multi.android-arm-armv6.apk
15:10:31     INFO - Sleeping 20 seconds...
15:10:51  WARNING - Try 2: Server returned status 404 HTTP Error 404: Not Found for http://ftp.mozilla.org/pub/mozilla.org/mobile/candidates/18.0-candidates/build1/unsigned/android-armv6/multi/fennec-18.0.multi.android-arm-armv6.apk
15:10:51     INFO - Sleeping 40 seconds...
15:11:31  WARNING - Try 3: Server returned status 404 HTTP Error 404: Not Found for http://ftp.mozilla.org/pub/mozilla.org/mobile/candidates/18.0-candidates/build1/unsigned/android-armv6/multi/fennec-18.0.multi.android-arm-armv6.apk
15:11:31     INFO - Sleeping 60 seconds...
15:12:31  WARNING - Try 4: Server returned status 404 HTTP Error 404: Not Found for http://ftp.mozilla.org/pub/mozilla.org/mobile/candidates/18.0-candidates/build1/unsigned/android-armv6/multi/fennec-18.0.multi.android-arm-armv6.apk
15:12:31     INFO - Sleeping 80 seconds...
15:13:51  WARNING - Try 5: Server returned status 404 HTTP Error 404: Not Found for http://ftp.mozilla.org/pub/mozilla.org/mobile/candidates/18.0-candidates/build1/unsigned/android-armv6/multi/fennec-18.0.multi.android-arm-armv6.apk
15:13:51     INFO - Sleeping 100 seconds...
15:15:31    ERROR - Try 6: Server returned status 404 HTTP Error 404: Not Found for http://ftp.mozilla.org/pub/mozilla.org/mobile/candidates/18.0-candidates/build1/unsigned/android-armv6/multi/fennec-18.0.multi.android-arm-armv6.apk
15:15:31    ERROR - Unable to download android-armv6:multi unsigned apk!
15:15:31    ERROR - Downloaded 29 of 31 unsigned apks successfully.

ie we retried in case there were issues with the file server but still couldn't get the files we wanted. ERROR was known state but we didn't stop execution, or make it BLINKy enough for the human to notice

Comment 1

[Aki Sasaki (not active)]

Historically, we had different sets of locales for different platforms so we sometimes expected some to fail.  I think I fixed this.

I did put a summary at the end for people to look at, but agreed, failing out is more noticeable.

I think this is pretty easy to do.

Comment 2

[Aki Sasaki (not active)]

Attachment: fatal() on a failed download

Comment 3

[Aki Sasaki (not active)]

Comment on attachment 698804 [details] [diff] [review]
fatal() on a failed download

http://hg.mozilla.org/build/mozharness/rev/60f39f4ac05d