Closed
Bug 827228
Opened 12 years ago
Closed 12 years ago
Calendar edit event header action button label should be should "Done" instead of "Save"
Categories
(Firefox OS Graveyard :: Gaia::Calendar, defect)
Tracking
(blocking-basecamp:-, b2g18+ fixed, b2g18-v1.0.1 fixed)
VERIFIED
FIXED
| blocking-basecamp | - |
People
(Reporter: caseyyee.ca, Assigned: arthurcc)
References
Details
(Keywords: late-l10n, Whiteboard: interaction, UX-P2, BerlinWW)
Attachments
(1 file)
|
180 bytes,
text/html
|
jlal
:
review+
lsblakk
:
approval-gaia-v1+
|
Details |
Change of header action button text to be consistent with other UI already in place.
|
||
Comment 1•12 years ago
|
||
Do you intend to request bb? on this?
Removing late-l10n assuming that you don't, if you try to get traction on this for the 1.x cycle, please add the keyword back.
Keywords: late-l10n
Yes I did
Re-noming and adding keyboard back.
blocking-basecamp: --- → ?
Keywords: late-l10n
|
||
Updated•12 years ago
|
blocking-basecamp: ? → -
tracking-b2g18:
--- → +
|
||
Updated•12 years ago
|
Whiteboard: interaction, UX-P2 → interaction, UX-P2, BerlinWW
|
Assignee | |
Updated•12 years ago
|
Assignee: nobody → arthur.chen
|
|
Assignee | |
Comment 3•12 years ago
|
||
Hi James, could you help review the change? I simply added another text and made the texts shown/hidden based on the propose. Thanks!
Attachment #699263 -
Flags: review?(jlal)
|
||
Comment 4•12 years ago
|
||
Comment on attachment 699263 [details]
Link to https://github.com/mozilla-b2g/gaia/pull/7389
Sorry! I had thought I marked r+ a long time ago...
Attachment #699263 -
Flags: review?(jlal) → review+
|
|
Assignee | |
Comment 5•12 years ago
|
||
Comment on attachment 699263 [details]
Link to https://github.com/mozilla-b2g/gaia/pull/7389
James, never mind. :)
[Approval Request Comment]
Bug caused by (feature/regressing bug #): 827228
User impact if declined: Users get confused between the event creating and modifying mode.
Testing completed: yes
Risk to taking this patch (and alternatives if risky): no risk
Attachment #699263 -
Flags: approval-gaia-master?(21)
|
||
Updated•12 years ago
|
Attachment #699263 -
Flags: approval-gaia-v1?(21) → approval-gaia-v1+
|
|
||
Comment 6•12 years ago
|
||
Status: NEW → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
|
||
Comment 7•12 years ago
|
||
v1-train: d2be3b1ccc93a0507399868d43f2fdefea5b9cc8
status-b2g18:
--- → fixed
|
||
Comment 8•12 years ago
|
||
The Calendar's edit event header action button label still reads "Save" instead of "Done"
2013-02-06-11-05-09 pvt nightly b2g18 build
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
|
||
Comment 9•12 years ago
|
||
Delphine - Can you file a followup bug for this and link it as a dependency?
Status: REOPENED → RESOLVED
Closed: 12 years ago → 12 years ago
Resolution: --- → FIXED
|
|
||
Comment 10•12 years ago
|
||
sure
|
|
||
Comment 11•12 years ago
|
||
Batch edit: bugs fixed on b2g18 since 1/25 branch of v1.0 are fixed on v1.0.1
status-b2g18-v1.0.1:
--- → fixed
|
|
||
Comment 12•12 years ago
|
||
looks good on today's Unagi pvt nightly build
Gecko: 5579b5a07aa29ca701df8e108772425cc14554e8
Gaia: c5a8b6476f0dbc456061227a7801e56634683eb0
BuildID: 20130319070203
Version 18.0
Status: RESOLVED → VERIFIED
You need to log in
before you can comment on or make changes to this bug.
Description
•