827235 - Add plugin-hang-ui@BIN_SUFFIX@ to SeaMonkey package manifest

Status: RESOLVED FIXED

(SeaMonkey :: Installer, defect)

Description

[Frank Wein [:mcsmurf]]

See http://hg.mozilla.org/mozilla-central/rev/1308210aefb4 (Bug 805591), a new file has been added to the FF package manifest to handle hung plugins. SeaMonkey package manifest should include that file, too.

Comment 1

[Frank Wein [:mcsmurf]]

Attachment: Patch

Very easy to review.

Comment 2

[Philip Chee]

Comment on attachment 730093 [details] [diff] [review]
Patch

r=me

You might also consider (in other bugs) porting installer changes from:

Bug 752982 - Part 1, implement captive portal detection service.
(probably responsible for some of our xpcshell oranges)
Bug 648407 - Allow to fold NSPR, NSS and SQLite libraries all together.
Bug 811548 - Move PageThumbs.jsm from /browser to /toolkit

Comment 3

[Frank Wein [:mcsmurf]]

Pushed: https://hg.mozilla.org/comm-central/rev/f500f6d4e9c7

Comment 4

[Frank Wein [:mcsmurf]]

Comment on attachment 730093 [details] [diff] [review]
Patch

[Approval Request Comment]
Regression caused by (bug #): -
User impact if declined: Bad user experience, Bug 805591 added a plugin hang UI that should also be included in SeaMonkey
Testing completed (on m-c, etc.): Feature works fine in Firefox, I tested this locally for quite a few weeks already (as the feature was included when building on your own PC)
Risk to taking this patch (and alternatives if risky): New GUI only gets called when a plugin causes problems, plus has already been tested in Firefox; so low risk I think
String changes made by this patch: -

Comment 5

[Philip Chee]

Comment on attachment 730093 [details] [diff] [review]
Patch

a=me

Comment 6

[Frank Wein [:mcsmurf]]

Pushed to comm-aurora: https://hg.mozilla.org/releases/comm-aurora/rev/8077003d5f7f

Comment 7

[Frank Wein [:mcsmurf]]

Pushed to comm-beta: https://hg.mozilla.org/releases/comm-beta/rev/fe3aceeaedb6

Comment 8

[Jens Hatlak (:InvisibleSmiley)]

This landed after the last 2.17 beta was tagged, so unless there'll be another 2.17 build, this is will not be fixed for SM 2.17 (but for anyone who builds default off comm-beta or to-be comm-release). Adjusted flags accordingly.

Comment 9

[Frank Wein [:mcsmurf]]

Jens: As far as I know the final SM 2.17 build will be built off the latest comm-beta revision, not off the last SM 2.17 beta build (Callek talked to me about this bug fix here :)

Comment 10

[Frank Wein [:mcsmurf]]

Or better said: The latest comm-beta revision will be moved to comm-release and then SM 2.17 will be built using that revision.

Comment 11

[Jens Hatlak (:InvisibleSmiley)]

Hmm OK, don't know how releng actually handles this. Until now I thought we wouldn't introduce any changes between the last beta and the final build, the rationale being that we would not have any beta user feedback for such changes. But this is not my call to make; esp. if you already talked to Callek about this.

Comment 12

[Frank Wein [:mcsmurf]]

Jens: The feature itself has been tested for a quite a while already in Firefox (and by me locally, though local test coverage could be better ;-).