Closed Bug 827279 Opened 7 years ago Closed 7 years ago

Show Accept/Decline buttons even for processed messages in imip bar

Categories

(Calendar :: E-mail based Scheduling (iTIP/iMIP), defect)

Lightning 2.2
defect
Not set

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: Fallen, Assigned: Fallen)

Details

Attachments

(2 files, 2 obsolete files)

Attached image Screenshot - v1 β€”
I closed bug 459689 as WFM since we now have the "Open" button, but this is not satisfying behavior especially for servers that already add the unprocessed item to the calendar. Users should have the possibility to accept/decline events even afterwards.

To get the best of both worlds, I have decided it makes sense to show the accept/decline buttons when the attendee status is still NEEDS-ACTION.

A next step would be to revise the bar to allow more options (i.e accept/decline/tentative AND the open button if its been processed), either as buttons or more superior UI. This can be done in yet another bug.
Attached patch Fix - v1 (obsolete) β€” β€” Splinter Review
Attachment #702912 - Flags: review?(matthew.mecca)
Attached patch Fix - v1 (obsolete) β€” β€” Splinter Review
Attachment #702912 - Attachment is obsolete: true
Attachment #702912 - Flags: review?(matthew.mecca)
Attachment #702914 - Flags: review?(matthew.mecca)
This doesn't seem to be working right for me - after accepting an invitation into a local or Google CalDAV calendar, the event is added into the calendar properly, with status "Confirmed", but the IMIP bar reads "This message contains an event that you have not yet responded to."
Attached patch Fix - v2 β€” β€” Splinter Review
This should do better. All these items in the itip code make my head spin, it was always taking the status from the invitation email item, instead of from the found item.
Attachment #702914 - Attachment is obsolete: true
Attachment #702914 - Flags: review?(matthew.mecca)
Attachment #721697 - Flags: review?(matthew.mecca)
Comment on attachment 721697 [details] [diff] [review]
Fix - v2

Looks good. r=mmecca
Attachment #721697 - Flags: review?(matthew.mecca) → review+
https://hg.mozilla.org/comm-central/rev/91b4d00571f5
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → 2.4
You need to log in before you can comment on or make changes to this bug.