Closed Bug 827298 Opened 10 years ago Closed 10 years ago

Some "Unknown size" entries lack generic icon and Remove from history context menu

Categories

(Firefox :: Downloads Panel, defect, P2)

Product:
Firefox
Component:
Downloads Panel
Type:
defect

Tracking

()

Status:
RESOLVED FIXED
Milestone:
Firefox 21
Tracking Flags:
Tracking Status
firefox20 --- fixed

People

(Reporter: mak, Assigned: mak)

References

Details

Attachments

(1 file, 1 obsolete file)

patch v1.1
3.80 KB, patch
mak
: review+
Gavin
: approval-mozilla-aurora+
Details | Diff | Splinter Review 
Some unknown size entries are missing the Remove from history contextual menuitem, and out of these entries some lack a generic file icon.
Blocks: ReleaseDownloadsPane
Priority: -- → P2
Assignee: nobody → mak77
Attached patch patch v1.0 (obsolete) — — Splinter Review 

        Attachment #698838 -
        Flags: review?(mano)

    
    

    
  

      
      
      
      

        Attached patch
          
          
        patch v1.1
        — 
          — Splinter Review
      

    


  
r=Mano over IRC on this version

        Attachment #698838 -
        Attachment is obsolete: true

        Attachment #698838 -
        Flags: review?(mano)

        Attachment #698875 -
        Flags: review+

    
    

    
  
https://hg.mozilla.org/mozilla-central/rev/77aed33eead5
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED

    
    

    
  
Comment on attachment 698875 [details] [diff] [review]
patch v1.1

[Approval Request Comment]
Bug caused by (feature/regressing bug #): Downloads panel feature
User impact if declined: Incomplete UI
Testing completed (on m-c, etc.): m-c
Risk to taking this patch (and alternatives if risky): Incomplete UI
String or UUID changes made by this patch: none

        Attachment #698875 -
        Flags: approval-mozilla-aurora?

        Attachment #698875 -
        Flags: approval-mozilla-aurora? → approval-mozilla-aurora+

          You need to log in
          before you can comment on or make changes to this bug.