827507 - JS for platform screenshot image handling breaks with FQDN in MEDIA_URL

Status: VERIFIED FIXED

(www.mozilla.org :: Bedrock, defect)

Description

[Paul [:pmac] McLanahan]

The JS in global.js in the init_platform_imgs() function doesn't expect more than one "." to be in the image URL, and thus converts all "."s in the domain name to ","s.

Comment 1

[Stephen Donner [:stephend] Not actively reading bugmail]

Web QA's automation caught this in http://qa-selenium.mv.mozilla.com:8080/view/Mozilla.com/job/mozilla.com.staging/770/testReport/

Comment 2

[Paul [:pmac] McLanahan]

Web QA ++!!

PR submitted: https://github.com/mozilla/bedrock/pull/572

Comment 3

[[github robot]]

Commit pushed to master at https://github.com/mozilla/bedrock

https://github.com/mozilla/bedrock/commit/560aaa4ff2eda6230c48041799c807909f4b5d35
Bug 827507: Fix platform screenshot js for FQDN media urls.

Comment 4

[raymond [:retornam] (inactive)]

automation no longer complains that this is broken. I will leave this open for a couple of days just to make sure we have completely fixed this.

Comment 5

[Paul [:pmac] McLanahan]

leave it open until wr turn on the CDN. thats when it would break if it were going to.

Comment 6

[Paul [:pmac] McLanahan]

Turned on CDN, still working.

Comment 7

[raymond [:retornam] (inactive)]

verified fixed  everything is working as expected