Closed
Bug 827513
Opened 11 years ago
Closed 11 years ago
Remove NotificationsComponents.manifest from SeaMonkey installer package manifest
Categories
(SeaMonkey :: Installer, defect)
SeaMonkey
Installer
Tracking
(seamonkey2.17 fixed)
RESOLVED
FIXED
seamonkey2.18
Tracking | Status | |
---|---|---|
seamonkey2.17 | --- | fixed |
People
(Reporter: mcsmurf, Assigned: mcsmurf)
Details
Attachments
(1 file)
2.25 KB,
patch
|
Callek
:
review+
Callek
:
feedback+
philip.chee
:
approval-comm-aurora+
|
Details | Diff | Splinter Review |
http://hg.mozilla.org/mozilla-central/rev/7647b05aa3f0 removed services/notifications, so components/NotificationsComponents.manifest needs to be removed from the SeaMonkey installer package manifest, too.
Assignee | ||
Comment 1•11 years ago
|
||
Removes everything related to MOZ_SERVICES_NOTIFICATIONS from comm-central. The second change in removed-files.in is needed because of the modules/* directive in the installer package manifest, the third change is for non-omnijar builds.
Assignee: installer → bugzilla
Status: NEW → ASSIGNED
Attachment #698967 -
Flags: review?(bugspam.Callek)
Comment 2•11 years ago
|
||
Comment on attachment 698967 [details] [diff] [review] Patch Review of attachment 698967 [details] [diff] [review]: ----------------------------------------------------------------- rs+ as bustage fix, I'll do a *real* review within the week though anyway, so leaving request open.
Attachment #698967 -
Flags: feedback+
Assignee | ||
Comment 3•11 years ago
|
||
Pushed: https://hg.mozilla.org/comm-central/rev/d744283dd331
Target Milestone: --- → seamonkey2.18
Assignee | ||
Comment 4•11 years ago
|
||
Comment on attachment 698967 [details] [diff] [review] Patch [Approval Request Comment] Regression caused by (bug #): - User impact if declined: SeaMonkey won't compile on comm-aurora Testing completed (on m-c, etc.): Works on comm-central, this patch ports Firefox Bug 791869 to SeaMonkey Risk to taking this patch (and alternatives if risky): build change only, no risk String changes made by this patch: -
Attachment #698967 -
Flags: approval-comm-aurora?
![]() |
||
Comment 5•11 years ago
|
||
Comment on attachment 698967 [details] [diff] [review] Patch a=me for comm-aurora.
Attachment #698967 -
Flags: approval-comm-aurora? → approval-comm-aurora+
Assignee | ||
Comment 6•11 years ago
|
||
Pushed: https://hg.mozilla.org/releases/comm-aurora/rev/131f2f3e65b8
Status: ASSIGNED → RESOLVED
Closed: 11 years ago
status-seamonkey2.17:
--- → fixed
Resolution: --- → FIXED
Comment 7•11 years ago
|
||
Comment on attachment 698967 [details] [diff] [review] Patch Review of attachment 698967 [details] [diff] [review]: ----------------------------------------------------------------- ...and I have a strange notion of "within the week" ::: suite/installer/package-manifest.in @@ -586,5 @@ > @BINPATH@/@PREF_DIR@/services-aitc.js > #endif > -#ifdef MOZ_SERVICES_NOTIFICATIONS > -@BINPATH@/@PREF_DIR@/services-notifications.js > -#endif Firefox kept this in, but I don't think they meant to.
Attachment #698967 -
Flags: review?(bugspam.Callek) → review+
You need to log in
before you can comment on or make changes to this bug.
Description
•