827513 - Remove NotificationsComponents.manifest from SeaMonkey installer package manifest

Status: RESOLVED FIXED

(SeaMonkey :: Installer, defect)

Description

[Frank Wein [:mcsmurf]]

http://hg.mozilla.org/mozilla-central/rev/7647b05aa3f0 removed services/notifications, so components/NotificationsComponents.manifest needs to be removed from the SeaMonkey installer package manifest, too.

Comment 1

[Frank Wein [:mcsmurf]]

Attachment: Patch

Removes everything related to MOZ_SERVICES_NOTIFICATIONS from comm-central. The second change in removed-files.in is needed because of the modules/* directive in the installer package manifest, the third change is for non-omnijar builds.

Comment 2

[Justin Wood (:Callek)]

Comment on attachment 698967 [details] [diff] [review]
Patch

Review of attachment 698967 [details] [diff] [review]:
-----------------------------------------------------------------

rs+ as bustage fix, I'll do a *real* review within the week though anyway, so leaving request open.

Comment 3

[Frank Wein [:mcsmurf]]

Pushed: https://hg.mozilla.org/comm-central/rev/d744283dd331

Comment 4

[Frank Wein [:mcsmurf]]

Comment on attachment 698967 [details] [diff] [review]
Patch

[Approval Request Comment]
Regression caused by (bug #): -
User impact if declined: SeaMonkey won't compile on comm-aurora
Testing completed (on m-c, etc.): Works on comm-central, this patch ports Firefox Bug 791869 to SeaMonkey
Risk to taking this patch (and alternatives if risky): build change only, no risk
String changes made by this patch: -

Comment 5

[Philip Chee]

Comment on attachment 698967 [details] [diff] [review]
Patch

a=me for comm-aurora.

Comment 6

[Frank Wein [:mcsmurf]]

Pushed: https://hg.mozilla.org/releases/comm-aurora/rev/131f2f3e65b8

Comment 7

[Justin Wood (:Callek)]

Comment on attachment 698967 [details] [diff] [review]
Patch

Review of attachment 698967 [details] [diff] [review]:
-----------------------------------------------------------------

...and I have a strange notion of "within the week"

::: suite/installer/package-manifest.in
@@ -586,5 @@
>  @BINPATH@/@PREF_DIR@/services-aitc.js
>  #endif
> -#ifdef MOZ_SERVICES_NOTIFICATIONS
> -@BINPATH@/@PREF_DIR@/services-notifications.js
> -#endif

Firefox kept this in, but I don't think they meant to.