827643 - turn off FAIL_ON_WARNINGS on win64 builder

Status: RESOLVED FIXED

(Firefox Build System :: General, defect)

Description

[Makoto Kato [:m_kato]]

Since win64 builder is tier-3, I don't think FAIL_ON_WARNINGS is unnecessary


Because, MSVC x64 generates C4267 warning the following code.

size_t length = 1;
int count;

count = length; <--- C4267 due to possible data loss.

so if we fix this, we need various code change. But Win64 is tier-3, we should not spend a time to fix this.

https://tbpl.mozilla.org/php/getParsedLog.php?id=18554040&tree=Firefox&full=1#error0

Comment 1

[Makoto Kato [:m_kato]]

Ohh, typo s/I don't think FAIL_ON_WARNINGS is unnecessary/s/I think FAIL_ON_WARNINGS is unnecessary....

Comment 2

[Makoto Kato [:m_kato]]

Attachment: fix

FAIL_ON_WARNINGS is unnecessary on Win64 builder.  Win64 compiler generates possible data loss warning...

I don't want to use -Wd option.  Because void* -> int/long casting should generate warning.

Comment 3

[Masatoshi Kimura [:emk]]

I think the comment should explain about what kind of conversion (in this case, size_t to int).

Comment 4

[(not currently active) Ted Mielczarek]

Comment on attachment 698984 [details] [diff] [review]
fix

Review of attachment 698984 [details] [diff] [review]:
-----------------------------------------------------------------

::: browser/config/mozconfigs/win64/debug
@@ +14,5 @@
>  fi
>  
> +# Don't turn on FAIL_ON_WARNINGS bacases Win64 compiler generates various
> +# possible loss warning (Bug 827643)
> +# ac_add_options --enable-warnings-as-errors

Do you want to just remove this line instead of commenting it out?

Comment 5

[Ed Morley [:emorley]]

Made comment 4 tweak and landed as:
https://hg.mozilla.org/mozilla-central/rev/c220bf4e8b6e

Comment 6

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/c220bf4e8b6e