Last Comment Bug 827691 - Treat [stack:nnnn] entries in /proc/self/maps as anonymous memory
: Treat [stack:nnnn] entries in /proc/self/maps as anonymous memory
Status: RESOLVED FIXED
[MemShrink]
:
Product: Core
Classification: Components
Component: XPCOM (show other bugs)
: Trunk
: All Linux
: -- normal (vote)
: mozilla21
Assigned To: Nicholas Nethercote [:njn]
:
: Nathan Froyd [:froydnj]
Mentors:
Depends on:
Blocks: 819769
  Show dependency treegraph
 
Reported: 2013-01-07 20:31 PST by Nicholas Nethercote [:njn]
Modified: 2013-01-16 12:31 PST (History)
3 users (show)
See Also:
Crash Signature:
(edit)
QA Whiteboard:
Iteration: ---
Points: ---
Has Regression Range: ---
Has STR: ---


Attachments
Treat [stack:nnnn] entries in /proc/self/maps as anonymous memory. (2.24 KB, patch)
2013-01-13 19:08 PST, Nicholas Nethercote [:njn]
justin.lebar+bug: review+
Details | Diff | Splinter Review

Description Nicholas Nethercote [:njn] 2013-01-07 20:31:25 PST
Bug 819769 comment 11 explained that [stack:nnnn] entries are best treated like anonymous memory.
Comment 1 Nicholas Nethercote [:njn] 2013-01-13 19:08:08 PST
Created attachment 701674 [details] [diff] [review]
Treat [stack:nnnn] entries in /proc/self/maps as anonymous memory.

Simple.
Comment 2 Justin Lebar (not reading bugmail) 2013-01-14 10:01:58 PST
Comment on attachment 701674 [details] [diff] [review]
Treat [stack:nnnn] entries in /proc/self/maps as anonymous memory.

My kingdom for nsAString::StartsWith.
Comment 3 Josh Matthews [:jdm] (on vacation until Dec 5) 2013-01-14 10:39:32 PST
http://mxr.mozilla.org/mozilla-central/source/xpcom/glue/nsStringAPI.h#1370

One kingdom, please.
Comment 4 Justin Lebar (not reading bugmail) 2013-01-14 10:45:29 PST
Do I get out of this on the technicality that it's not a method on nsAString?  :)
Comment 5 Nicholas Nethercote [:njn] 2013-01-15 17:19:58 PST
https://hg.mozilla.org/integration/mozilla-inbound/rev/ffef8f23abd4
Comment 6 Ed Morley [:emorley] 2013-01-16 12:31:26 PST
https://hg.mozilla.org/mozilla-central/rev/ffef8f23abd4

Note You need to log in before you can comment on or make changes to this bug.