Closed
Bug 827717
Opened 12 years ago
Closed 12 years ago
honor dynamic changes to animation-delay after a CSS animation starts
Categories
(Core :: CSS Parsing and Computation, defect, P3)
Core
CSS Parsing and Computation
Tracking
()
RESOLVED
FIXED
mozilla21
People
(Reporter: dbaron, Assigned: dbaron)
Details
Attachments
(1 file)
We should honor dynamic changes to animation-delay after a CSS animation starts by remembering the start time that's at the beginning of the delay rather than the end. This is per CSS WG resolution (see commit message in patch).
|
Assignee | |
Comment 1•12 years ago
|
||
Attachment #699032 -
Flags: review?(bzbarsky)
|
|
Assignee | |
Comment 2•12 years ago
|
||
|
||
Comment 3•12 years ago
|
||
Comment on attachment 699032 [details] [diff] [review]
Change record of CSS animation start to be before delay so that dynamic changes to animation-delay are honored.
>+ ElementAnimations::GetPositionInIteration(animation.startTime() - aPoint,
Shouldn't that be aPoint - animation.startTime()?
r=me with that fixed
Attachment #699032 -
Flags: review?(bzbarsky) → review+
|
|
Assignee | |
Comment 4•12 years ago
|
||
(In reply to Boris Zbarsky (:bz) from comment #3)
> Comment on attachment 699032 [details] [diff] [review]
> Change record of CSS animation start to be before delay so that dynamic
> changes to animation-delay are honored.
>
> >+ ElementAnimations::GetPositionInIteration(animation.startTime() - aPoint,
>
> Shouldn't that be aPoint - animation.startTime()?
Indeed. One of these months I think I'm going to have to talk someone into writing tests for OMTA or do so myself...
|
|
Assignee | |
Comment 5•12 years ago
|
||
|
||
Comment 6•12 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla21
|
|
||
Comment 7•12 years ago
|
||
|
|
||
Comment 8•12 years ago
|
||
You need to log in
before you can comment on or make changes to this bug.
Description
•