Closed Bug 827717 Opened 7 years ago Closed 7 years ago

honor dynamic changes to animation-delay after a CSS animation starts

Categories

(Core :: CSS Parsing and Computation, defect, P3)

Product:
Core
Component:
CSS Parsing and Computation
Type:
defect

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla21

People

(Reporter: dbaron, Assigned: dbaron)

Details

Attachments

(1 file)

Change record of CSS animation start to be before delay so that dynamic changes to animation-delay are honored.
15.91 KB, patch
bzbarsky
: review+
Details | Diff | Splinter Review 
We should honor dynamic changes to animation-delay after a CSS animation starts by remembering the start time that's at the beginning of the delay rather than the end.  This is per CSS WG resolution (see commit message in patch).
Comment on attachment 699032 [details] [diff] [review]
Change record of CSS animation start to be before delay so that dynamic changes to animation-delay are honored.

>+      ElementAnimations::GetPositionInIteration(animation.startTime() - aPoint,

Shouldn't that be aPoint - animation.startTime()?

r=me with that fixed
Attachment #699032 - Flags: review?(bzbarsky) → review+
(In reply to Boris Zbarsky (:bz) from comment #3)
> Comment on attachment 699032 [details] [diff] [review]
> Change record of CSS animation start to be before delay so that dynamic
> changes to animation-delay are honored.
> 
> >+      ElementAnimations::GetPositionInIteration(animation.startTime() - aPoint,
> 
> Shouldn't that be aPoint - animation.startTime()?

Indeed.  One of these months I think I'm going to have to talk someone into writing tests for OMTA or do so myself...
https://hg.mozilla.org/mozilla-central/rev/dcdb6d839e95
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla21
You need to log in before you can comment on or make changes to this bug.