Closed
Bug 827717
Opened 11 years ago
Closed 11 years ago
honor dynamic changes to animation-delay after a CSS animation starts
Categories
(Core :: CSS Parsing and Computation, defect, P3)
Core
CSS Parsing and Computation
Tracking
()
RESOLVED
FIXED
mozilla21
People
(Reporter: dbaron, Assigned: dbaron)
Details
Attachments
(1 file)
We should honor dynamic changes to animation-delay after a CSS animation starts by remembering the start time that's at the beginning of the delay rather than the end. This is per CSS WG resolution (see commit message in patch).
Assignee | ||
Comment 1•11 years ago
|
||
Attachment #699032 -
Flags: review?(bzbarsky)
Assignee | ||
Comment 2•11 years ago
|
||
https://tbpl.mozilla.org/?tree=Try&rev=e63a1700f149
![]() |
||
Comment 3•11 years ago
|
||
Comment on attachment 699032 [details] [diff] [review] Change record of CSS animation start to be before delay so that dynamic changes to animation-delay are honored. >+ ElementAnimations::GetPositionInIteration(animation.startTime() - aPoint, Shouldn't that be aPoint - animation.startTime()? r=me with that fixed
Attachment #699032 -
Flags: review?(bzbarsky) → review+
Assignee | ||
Comment 4•11 years ago
|
||
(In reply to Boris Zbarsky (:bz) from comment #3) > Comment on attachment 699032 [details] [diff] [review] > Change record of CSS animation start to be before delay so that dynamic > changes to animation-delay are honored. > > >+ ElementAnimations::GetPositionInIteration(animation.startTime() - aPoint, > > Shouldn't that be aPoint - animation.startTime()? Indeed. One of these months I think I'm going to have to talk someone into writing tests for OMTA or do so myself...
Assignee | ||
Comment 5•11 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/dcdb6d839e95
Comment 6•11 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/dcdb6d839e95
Status: ASSIGNED → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla21
Comment 7•11 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/dcdb6d839e95
Comment 8•11 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/dcdb6d839e95
You need to log in
before you can comment on or make changes to this bug.
Description
•