827717 - honor dynamic changes to animation-delay after a CSS animation starts

Status: RESOLVED FIXED

(Core :: CSS Parsing and Computation, defect, P3)

Description

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

We should honor dynamic changes to animation-delay after a CSS animation starts by remembering the start time that's at the beginning of the delay rather than the end.  This is per CSS WG resolution (see commit message in patch).

Comment 1

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Attachment: Change record of CSS animation start to be before delay so that dynamic changes to animation-delay are honored.

Comment 2

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

https://tbpl.mozilla.org/?tree=Try&rev=e63a1700f149

Comment 3

[Boris Zbarsky [:bzbarsky]]

Comment on attachment 699032 [details] [diff] [review]
Change record of CSS animation start to be before delay so that dynamic changes to animation-delay are honored.

>+      ElementAnimations::GetPositionInIteration(animation.startTime() - aPoint,

Shouldn't that be aPoint - animation.startTime()?

r=me with that fixed

Comment 4

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

(In reply to Boris Zbarsky (:bz) from comment #3)
> Comment on attachment 699032 [details] [diff] [review]
> Change record of CSS animation start to be before delay so that dynamic
> changes to animation-delay are honored.
> 
> >+      ElementAnimations::GetPositionInIteration(animation.startTime() - aPoint,
> 
> Shouldn't that be aPoint - animation.startTime()?

Indeed.  One of these months I think I'm going to have to talk someone into writing tests for OMTA or do so myself...

Comment 5

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/dcdb6d839e95

Comment 6

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/dcdb6d839e95

Comment 7

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/dcdb6d839e95

Comment 8

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/dcdb6d839e95