827740 - B2G needs to handle IndexedDB quota prompts

Status: RESOLVED FIXED

(Firefox OS Graveyard :: General, defect)

Description

[Ben Turner (not reading bugmail, use the needinfo flag!)]

Attachment: Patch, v1

Talked with everyone today and we decided that v1 can simply deny all quota increase requests. Attached patch should automatically do that.

Comment 1

[Jonas Sicking (:sicking) No longer reading bugmail consistently]

Comment on attachment 699071 [details] [diff] [review]
Patch, v1

Review of attachment 699071 [details] [diff] [review]:
-----------------------------------------------------------------

::: b2g/chrome/content/shell.js
@@ +836,5 @@
>  }
>  
> +var IndexedDBPromptHelper = {
> +  _quotaPrompt: "indexedDB-quota-prompt",
> +  _quotaResponse: "indexedDB-quota-response",

r-

@@ +860,5 @@
> +    var responseTopic = this._quotaResponse;
> +
> +    setTimeout(function() {
> +      observer.observe(null, responseTopic,
> +                       Ci.nsIPermissionManager.Deny_ACTION);

r--

Comment 2

[Ben Turner (not reading bugmail, use the needinfo flag!)]

Attachment: Patch, v1.1

Oops, s/Deny/DENY/

Comment 3

[Ben Turner (not reading bugmail, use the needinfo flag!)]

This patch works, but fabrice wants us to do a real prompt rather than deny automatically. Over to Dale for that :)

Comment 4

[Ben Turner (not reading bugmail, use the needinfo flag!)]

Ok, nevermind, we're going with this for v1.

Comment 5

[Dale Harvey (:daleharvey)]

Attachment: WIP for idb prompts - Gecko

Backing up for when we want to implement prompts

Comment 6

[Dale Harvey (:daleharvey)]

Attachment: WIP for idb prompts - Gaia

Backing up for when we implement prompts

Comment 7

[[:fabrice] Fabrice Desré]

Comment on attachment 699074 [details] [diff] [review]
Patch, v1.1

Review of attachment 699074 [details] [diff] [review]:
-----------------------------------------------------------------

r=me with s/var/let

Comment 8

[Dale Harvey (:daleharvey)]

Attachment: Deny requests for more indexedDB quota from content

I just addressed the nits and formatted the ptach for checkin

Comment 9

[[:fabrice] Fabrice Desré]

https://hg.mozilla.org/integration/mozilla-inbound/rev/08c6579a454b

Comment 10

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/08c6579a454b

Comment 11

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-b2g18/rev/c5cd0da334fd

Comment 12

[Ben Kelly [:bkelly, not reviewing]]

Was there ever a follow-up filed to implement the real prompt for IDB quota increase?

Comment 13

[[:fabrice] Fabrice Desré]

(In reply to Ben Kelly [:bkelly] from comment #12)
> Was there ever a follow-up filed to implement the real prompt for IDB quota
> increase?

Looks like no. Any app can opt-in to unlimited indexedDB with the "storage" permission (even non privileged ones). So we only limit web sites.

Comment 14

[Ben Turner (not reading bugmail, use the needinfo flag!)]

Correct for B2G. Web sites are never allowed to go beyond their first quota limit (it's as if the user always picks the 'deny' option). Apps are in the same boat by default unless they have the 'storage' permission as fabrice notes.

Comment 15

[Ben Kelly [:bkelly, not reviewing]]

So if an app needs to work with a large IDB, they should add 'storage' to their manifest even if they don't use the storage API explicitly?  That seems a bit unintuitive to me.

See this dev-gaia thread for context:

  https://groups.google.com/forum/#!topic/mozilla.dev.gaia/5cbE9o_buhY

Comment 16

[Dale Harvey (:daleharvey)]

> Correct for B2G. Web sites are never allowed to go beyond their first quota limit (it's as if the user always picks the 'deny' option). Apps are in the same boat by default unless they have the 'storage' permission as fabrice notes.

But we should fix that right? we want more web content to 'just work' and less dependency on people to create fxos only manifests

Comment 17

[Jonas Sicking (:sicking) No longer reading bugmail consistently]

Yes. A lot of the storage backend is being rewritten currently. Once that's done we should have an easier time getting prompts properly working on B2G.

Comment 18

[Dale Harvey (:daleharvey)]

The patch to support this seems fairly simple, opened a new bug and will try to see about getting it working for 2.1

https://bugzilla.mozilla.org/show_bug.cgi?id=1048696