Closed
Bug 827824
Opened 13 years ago
Closed 13 years ago
SPDY uses maybe signed type for unsigned buffer
Categories
(Core :: Networking: HTTP, defect)
Core
Networking: HTTP
Tracking
()
RESOLVED
FIXED
mozilla21
People
(Reporter: emk, Assigned: emk)
References
Details
(Whiteboard: [spdy])
Attachments
(1 file)
|
7.64 KB,
patch
|
mcmanus
:
review+
|
Details | Diff | Splinter Review |
See bug 827032 for details.
|
||
Comment 1•13 years ago
|
||
> > MSVC warns at the following line in SpdyStream3::ParseHttpRequestHeaders...
> > Indeed 7 << 5 (= 0xF0) is out of the range of (signed) char.
>
> Sounds like we should run this by :mcmanus then--might be a bug.
Assignee: nobody → mcmanus
Whiteboard: [spdy]
|
||
Comment 2•13 years ago
|
||
emk,
Just put all the SPDY changes from bug 827032 into this bug and ask mcmanus for review.
|
Assignee | |
Comment 3•13 years ago
|
||
Sliced out from bug 827032.
|
|
||
Comment 4•13 years ago
|
||
Comment on attachment 699216 [details] [diff] [review]
Use uint8_t for mTxInlineFrame
Thanks!
sorry about the delay.. this kinda got lost in my mailbox.
Attachment #699216 -
Flags: review?(mcmanus) → review+
|
|
Assignee | |
Comment 5•13 years ago
|
||
Flags: in-testsuite-
|
||
Comment 6•13 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla21
You need to log in
before you can comment on or make changes to this bug.
Description
•