Closed Bug 827824 Opened 7 years ago Closed 7 years ago
SPDY uses maybe signed type for unsigned buffer
See bug 827032 for details.
> > MSVC warns at the following line in SpdyStream3::ParseHttpRequestHeaders... > > Indeed 7 << 5 (= 0xF0) is out of the range of (signed) char. > > Sounds like we should run this by :mcmanus then--might be a bug.
Assignee: nobody → mcmanus
emk, Just put all the SPDY changes from bug 827032 into this bug and ask mcmanus for review.
Sliced out from bug 827032.
Assignee: mcmanus → VYV03354
Status: NEW → ASSIGNED
Attachment #699216 - Flags: review?(mcmanus)
Comment on attachment 699216 [details] [diff] [review] Use uint8_t for mTxInlineFrame Thanks! sorry about the delay.. this kinda got lost in my mailbox.
Attachment #699216 - Flags: review?(mcmanus) → review+
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla21
You need to log in before you can comment on or make changes to this bug.