827851 - Building testpilot broken, breaking building Aurora nightlies

Status: RESOLVED FIXED

(Firefox Build System :: General, defect)

Description

[Phil Ringnalda (:philor)]

e.g. https://tbpl.mozilla.org/php/getParsedLog.php?id=18588038&tree=Mozilla-Aurora

cd [e-mail] && \
	/usr/bin/zip -r9XD /builds/slave/m-aurora-lnx-ntly/build/obj-firefox/browser/app/profile/extensions/../../../../dist/bin/distribution/extensions/[e-mail] * -x \*.in -x \*.mkdir.done
zip I/O error: No such file or directory
zip error: Could not create output file (/builds/slave/m-aurora-lnx-ntly/build/obj-firefox/browser/app/profile/extensions/../../../../dist/bin/distribution/extensions/[e-mail])
make[8]: Leaving directory `/builds/slave/m-aurora-lnx-ntly/build/obj-firefox/browser/app/profile/extensions'
make[8]: *** [/builds/slave/m-aurora-lnx-ntly/build/obj-firefox/browser/app/profile/extensions/../../../../dist/bin/distribution/extensions/[e-mail]] Error 15

Since bug 822017 is the only time we've touched it in months, it seems likely.

Comment 1

[Alex Keybl [:akeybl]]

Ehsan - can you take a look this morning? We'll want to spin Aurora as soon as this is resolved.

Comment 2

[(no longer active)]

Attachment: Patch (v1)

The problem is that we never create dist/bin/distribution/extensions.

This patch fixes it.

Comment 3

[Mike Hommey [:glandium]]

Comment on attachment 699271 [details] [diff] [review]
Patch (v1)

Review of attachment 699271 [details] [diff] [review]:
-----------------------------------------------------------------

::: browser/app/profile/extensions/Makefile.in
@@ +28,4 @@
>  GARBAGE += $(all_xpis)
>  
>  $(all_xpis): $(DISTROEXT)/%.xpi: $(call mkdir_deps,$(DISTROEXT)) libs-%
> +	mkdir -p $(DISTROEXT) && \

$(call mkdir_deps,$(DISTROEXT)) is supposed to create that directory.

Comment 4

[(no longer active)]

(In reply to comment #3)
> Comment on attachment 699271 [details] [diff] [review]
>   --> https://bugzilla.mozilla.org/attachment.cgi?id=699271
> Patch (v1)
> 
> Review of attachment 699271 [details] [diff] [review]:
> -----------------------------------------------------------------
> 
> ::: browser/app/profile/extensions/Makefile.in
> @@ +28,4 @@
> >  GARBAGE += $(all_xpis)
> >  
> >  $(all_xpis): $(DISTROEXT)/%.xpi: $(call mkdir_deps,$(DISTROEXT)) libs-%
> > +	mkdir -p $(DISTROEXT) && \
> 
> $(call mkdir_deps,$(DISTROEXT)) is supposed to create that directory.

Well, it doesn't.  See the build log.

Comment 5

[Mike Hommey [:glandium]]

Attachment: Move the rules from bug 822017 after including rules.mk

Subtle case of variables not being there before including rules.mk. Can't move everything since INSTALL_TARGETS requires rules.mk to be included afterwards. And no need for an ifdef because all_xpis is not defined unless the original ifdef matches.

Comment 6

[(no longer active)]

Comment on attachment 699285 [details] [diff] [review]
Move the rules from bug 822017 after including rules.mk

This blocks builds.

Comment 7

[(no longer active)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/3a5db98b87e4

Comment 8

[Alex Keybl [:akeybl]]

Comment on attachment 699285 [details] [diff] [review]
Move the rules from bug 822017 after including rules.mk

[Triage Comment]
Approving for Aurora, so that we can spin up a nightly. Thanks all!

Comment 9

[(no longer active)]

https://hg.mozilla.org/releases/mozilla-aurora/rev/419d065f63b9

Comment 10

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/3a5db98b87e4