827887 - We get the downloadavailable event for packaged apps that didn't change

Status: RESOLVED WORKSFORME

(Core Graveyard :: DOM: Apps, defect)

Description

[Julien Wajsberg [:julienw]]

STR:
* install app at http://www.everlong.org/mozilla/packaged/
* install the packaged app at http://gomette.com/webapps/
* go to settings > device information and click on "check now"

expected:
* no download available

actual:
* we get a download available event for both apps.
=> after 30 sec we get the notification that the two apps have an update

I suspect something is not working correctly with the Etag.

Comment 1

[Johnny Stenback (:jst)]

Fabrice will investigate here before we can tell whether it's a blocker or not.

Comment 2

[Etienne Segonzac (:etienne)]

(In reply to Julien Wajsberg [:julienw] from comment #0)
> STR:
> * install the packaged app at http://gomette.com/webapps/

Wait, you said you were just going to install it :)
The server for this app won't do anything with the if-none-match header and always return a 200 (and not a 301) so we *should* always see an update.

So this might be an invalid bug.

Comment 3

[Etienne Segonzac (:etienne)]

(In reply to Etienne Segonzac (:etienne) from comment #2)
> (In reply to Julien Wajsberg [:julienw] from comment #0)
> > STR:
> > * install the packaged app at http://gomette.com/webapps/
> 
> Wait, you said you were just going to install it :)
> The server for this app won't do anything with the if-none-match header and
> always return a 200 (and not a 301) so we *should* always see an update.
> 
> So this might be an invalid bug.

s/301/304

Comment 4

[Julien Wajsberg [:julienw]]

My server does things correctly with ETag and I just verified that I get a 304 and still get a download available event.

Comment 5

[Julien Wajsberg [:julienw]]

Attachment: debug patch for gecko

Comment 6

[Julien Wajsberg [:julienw]]

Attachment: debug patch for gaia

this patch adds logs, disables system updates, and shortens the notification timeout.

Comment 7

[Julien Wajsberg [:julienw]]

Actually you can only try with the packaged app on everlong.org. At first I thought I needed to install two apps to make the bug more evident, but it's happening with only one.

Comment 8

[Julien Wajsberg [:julienw]]

This seems to have been fixed by other changes (don't know which one though).

Can't reproduce now.