group list should be imported (Outlook and Outlook Express)

VERIFIED FIXED in mozilla1.0

Status

P2
normal
VERIFIED FIXED
18 years ago
14 years ago

People

(Reporter: fenella, Assigned: cavin)

Tracking

Trunk
mozilla1.0
x86
Windows NT
Dependency tree / graph

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: [ADT NEED INFO] nab-imp,imp-failure)

Attachments

(2 attachments)

(Reporter)

Description

18 years ago
Win32 (2001-05-24-06 trunk)
1. In Outlook Express, create an address book that contains a group list
2. From Seamonkey, do a File|Import
3. Select Outlook Express
4. Check Address Book from Outlook Express
Actual result: Group list has not been imported
Expected result: Group list should be imported too.
(Reporter)

Comment 1

18 years ago
Also,
The business section:
work address, city, state, zip code and country are not imported.

Updated

17 years ago
QA Contact: fenella → nbaca

Comment 2

17 years ago
Branch build 2001-09-14: WinMe
Still a problem, marking nsbranch because I would assume this is important to
Enterprise?
Keywords: nsbranch

Comment 3

17 years ago
I would not hold the release for this. Minusing. triaging for the next release.
Keywords: nsbranch → nsbranch-
Target Milestone: --- → mozilla0.9.6

Comment 4

17 years ago
reassigning to cavin
Assignee: chuang → cavin

Comment 5

17 years ago
moving to 1.0
Target Milestone: mozilla0.9.6 → mozilla1.0

Updated

17 years ago
Blocks: 107067

Updated

17 years ago
Keywords: nsbranch-

Updated

17 years ago
Keywords: nsbeta1

Comment 6

17 years ago
Bugs targeted at mozilla1.0 without the mozilla1.0 keyword moved to mozilla1.0.1 
(you can query for this string to delete spam or retrieve the list of bugs I've 
moved)
Target Milestone: mozilla1.0 → mozilla1.0.1

Updated

17 years ago
Keywords: nsbeta1 → nsbeta1+
Priority: -- → P2

Updated

17 years ago
Whiteboard: nab-imp

Updated

17 years ago
Whiteboard: nab-imp → nab-imp,imp-failure

Updated

17 years ago
Summary: Outlook Express group list should be imported → roup list should be imported (Outlook and Outlook Express)

Updated

17 years ago
Status: NEW → ASSIGNED
Summary: roup list should be imported (Outlook and Outlook Express) → group list should be imported (Outlook and Outlook Express)
Target Milestone: mozilla1.0.1 → mozilla1.0

Updated

17 years ago
Blocks: 126318

Updated

17 years ago
Blocks: 128661

Comment 7

17 years ago
ADT needs more info, does this still happen?
Whiteboard: nab-imp,imp-failure → [ADT NEED INFO] nab-imp,imp-failure
(Assignee)

Comment 8

17 years ago
Yes it does because this has never been supported (ie, no code to do list import).
(Assignee)

Comment 9

17 years ago
Created attachment 75457 [details] [diff] [review]
Proposed patch, v1

Allows OE and Outlook lists/groups to be imported and fixes the problem of not
showing summary info at the end of import. Members of lists are not imported
due to not being able to retrieve the member values.

Updated

17 years ago
Attachment #75457 - Flags: review+
Comment on attachment 75457 [details] [diff] [review]
Proposed patch, v1

+  nsIStringBundle *pBundle = nsOEStringBundle::GetStringBundleProxy();
...[snap]...
+  NS_IF_RELEASE( pBundle);

Appart that, R=ducarroz
three comments, address these and then sr=sspitzer

1)

+  nsIMdbRow* newRow = nsnull;
+  rv = m_database->GetNewListRow(&newRow);
+  NS_ENSURE_SUCCESS(rv, rv);

are you leaking newRow?

Use a nsCOMPtr, like this:

    nsCOMPtr <nsIMdbRow> newRow;
    rv = m_database->GetNewListRow(getter_AddRefs(newRow));


2)
     
+  nsString	name;
+  if (SUCCEEDED(hr))
+  {
+    PRUnichar * pName;
+    if (NS_SUCCEEDED( source->GetPreferredName( &pName)))
+    {
+      name = pName;
+      nsCRT::free( pName);
+    }
+    ReportSuccess( name, &success);

you can use an nsXPIDLString here, to avoid the free.

3)

+  nsIMdbRow* newRow = nsnull;
+  rv = pDb->GetNewListRow(&newRow);
+  NS_ENSURE_SUCCESS(rv, rv);

are you leaking newRow?

Use a nsCOMPtr, like this:

    nsCOMPtr <nsIMdbRow> newRow;
    rv = pDb->GetNewListRow(getter_AddRefs(newRow));
(Assignee)

Comment 12

17 years ago
Ok, I'll do that before checking in the patch.
Cavin writes "i got the code from some eudora import..."

I saw that there was similar code in nsTextAddress::AddLdifRowToDatabase, too.
If you determine we are leaking, can you fix the other instance as well?
another alternative for

+  nsString	name;
+  if (SUCCEEDED(hr))
+  {
+    PRUnichar * pName;
+    if (NS_SUCCEEDED( source->GetPreferredName( &pName)))
+    {
+      name = pName;
+      nsCRT::free( pName);
+    }
+    ReportSuccess( name, &success);

is something like:

+  nsString	name;
+  PRUnichar *	pName;
+  if (NS_SUCCEEDED(source->GetPreferredName( &pName))) {
+    name.Adopt(pName);
+  }

(Assignee)

Comment 15

17 years ago
> I saw that there was similar code in nsTextAddress::AddLdifRowToDatabase, too.
> If you determine we are leaking, can you fix the other instance as well?
>
OK, I'll do that before checking it in.

Comment 16

17 years ago
Comment on attachment 75457 [details] [diff] [review]
Proposed patch, v1

a=asa (on behalf of drivers) for checkin to the 1.0 trunk
Attachment #75457 - Flags: approval+
(Assignee)

Comment 17

17 years ago
Fix checked in.
Status: ASSIGNED → RESOLVED
Last Resolved: 17 years ago
Resolution: --- → FIXED

Comment 18

17 years ago
Trunk build 2002-03-26: WinMe
Reopen.

- Import Outlook Express fails. I should see 2 groups and 5 contacts but I only 
see 1 group and 1 member. I noticed that the group that was imported is the 
first group listed in OE. Also the contact that is imported is the first contact 
listed in OE.

- Import Outlook: ok.
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
(Assignee)

Comment 19

17 years ago
Created attachment 76431 [details] [diff] [review]
Change return value type to nsresult to make while loop works correctly
Comment on attachment 76431 [details] [diff] [review]
Change return value type to nsresult to make while loop works correctly

sr=sspitzer
Attachment #76431 - Flags: superreview+
Comment on attachment 76431 [details] [diff] [review]
Change return value type to nsresult to make while loop works correctly

R=ducarroz
Attachment #76431 - Flags: review+

Comment 22

17 years ago
Comment on attachment 76431 [details] [diff] [review]
Change return value type to nsresult to make while loop works correctly

a=asa (on behalf of drivers) for checkin to the 1.0 trunk
Attachment #76431 - Flags: approval+
(Assignee)

Comment 23

17 years ago
Fix checked in.
Status: REOPENED → RESOLVED
Last Resolved: 17 years ago17 years ago
Resolution: --- → FIXED

Comment 24

17 years ago
Trunk build 2002-04-01: WinMe
Verified Fixed. 

- All cards and their content are imported
- The names of the lists are present but not the content as described in 
Comment#9.
Status: RESOLVED → VERIFIED
Product: Browser → Seamonkey
You need to log in before you can comment on or make changes to this bug.