82791 - group list should be imported (Outlook and Outlook Express)

Status: VERIFIED FIXED

(SeaMonkey :: MailNews: Address Book & Contacts, defect, P2)

Description

[fenella]

Win32 (2001-05-24-06 trunk)
1. In Outlook Express, create an address book that contains a group list
2. From Seamonkey, do a File|Import
3. Select Outlook Express
4. Check Address Book from Outlook Express
Actual result: Group list has not been imported
Expected result: Group list should be imported too.

Comment 1

[fenella]

Also,
The business section:
work address, city, state, zip code and country are not imported.

Comment 2

[Ninoschka Baca]

Branch build 2001-09-14: WinMe
Still a problem, marking nsbranch because I would assume this is important to
Enterprise?

Comment 3

[Scott MacGregor]

I would not hold the release for this. Minusing. triaging for the next release.

Comment 4

[scottputterman]

reassigning to cavin

Comment 5

[scottputterman]

moving to 1.0

Comment 6

[Asa Dotzler [:asa]]

Bugs targeted at mozilla1.0 without the mozilla1.0 keyword moved to mozilla1.0.1 
(you can query for this string to delete spam or retrieve the list of bugs I've 
moved)

Comment 7

[saari (gone)]

ADT needs more info, does this still happen?

Comment 8

[Cavin Song]

Yes it does because this has never been supported (ie, no code to do list import).

Comment 9

[Cavin Song]

Attachment: Proposed patch, v1

Allows OE and Outlook lists/groups to be imported and fixes the problem of not
showing summary info at the end of import. Members of lists are not imported
due to not being able to retrieve the member values.

Comment 10

[Jean-Francois Ducarroz]

Comment on attachment 75457 [details] [diff] [review]
Proposed patch, v1

+  nsIStringBundle *pBundle = nsOEStringBundle::GetStringBundleProxy();
...[snap]...
+  NS_IF_RELEASE( pBundle);

Appart that, R=ducarroz

Comment 11

[(not reading, please use [e-mail] instead)]

three comments, address these and then sr=sspitzer

1)

+  nsIMdbRow* newRow = nsnull;
+  rv = m_database->GetNewListRow(&newRow);
+  NS_ENSURE_SUCCESS(rv, rv);

are you leaking newRow?

Use a nsCOMPtr, like this:

    nsCOMPtr <nsIMdbRow> newRow;
    rv = m_database->GetNewListRow(getter_AddRefs(newRow));


2)
     
+  nsString	name;
+  if (SUCCEEDED(hr))
+  {
+    PRUnichar * pName;
+    if (NS_SUCCEEDED( source->GetPreferredName( &pName)))
+    {
+      name = pName;
+      nsCRT::free( pName);
+    }
+    ReportSuccess( name, &success);

you can use an nsXPIDLString here, to avoid the free.

3)

+  nsIMdbRow* newRow = nsnull;
+  rv = pDb->GetNewListRow(&newRow);
+  NS_ENSURE_SUCCESS(rv, rv);

are you leaking newRow?

Use a nsCOMPtr, like this:

    nsCOMPtr <nsIMdbRow> newRow;
    rv = pDb->GetNewListRow(getter_AddRefs(newRow));

Comment 12

[Cavin Song]

Ok, I'll do that before checking in the patch.

Comment 13

[(not reading, please use [e-mail] instead)]

Cavin writes "i got the code from some eudora import..."

I saw that there was similar code in nsTextAddress::AddLdifRowToDatabase, too.
If you determine we are leaking, can you fix the other instance as well?

Comment 14

[(not reading, please use [e-mail] instead)]

another alternative for

+  nsString	name;
+  if (SUCCEEDED(hr))
+  {
+    PRUnichar * pName;
+    if (NS_SUCCEEDED( source->GetPreferredName( &pName)))
+    {
+      name = pName;
+      nsCRT::free( pName);
+    }
+    ReportSuccess( name, &success);

is something like:

+  nsString	name;
+  PRUnichar *	pName;
+  if (NS_SUCCEEDED(source->GetPreferredName( &pName))) {
+    name.Adopt(pName);
+  }

Comment 15

[Cavin Song]

> I saw that there was similar code in nsTextAddress::AddLdifRowToDatabase, too.
> If you determine we are leaking, can you fix the other instance as well?
>
OK, I'll do that before checking it in.

Comment 16

[Asa Dotzler [:asa]]

Comment on attachment 75457 [details] [diff] [review]
Proposed patch, v1

a=asa (on behalf of drivers) for checkin to the 1.0 trunk

Comment 17

[Cavin Song]

Fix checked in.

Comment 18

[Ninoschka Baca]

Trunk build 2002-03-26: WinMe
Reopen.

- Import Outlook Express fails. I should see 2 groups and 5 contacts but I only 
see 1 group and 1 member. I noticed that the group that was imported is the 
first group listed in OE. Also the contact that is imported is the first contact 
listed in OE.

- Import Outlook: ok.

Comment 19

[Cavin Song]

Attachment: Change return value type to nsresult to make while loop works correctly

Comment 20

[(not reading, please use [e-mail] instead)]

Comment on attachment 76431 [details] [diff] [review]
Change return value type to nsresult to make while loop works correctly

sr=sspitzer

Comment 21

[Jean-Francois Ducarroz]

Comment on attachment 76431 [details] [diff] [review]
Change return value type to nsresult to make while loop works correctly

R=ducarroz

Comment 22

[Asa Dotzler [:asa]]

Comment on attachment 76431 [details] [diff] [review]
Change return value type to nsresult to make while loop works correctly

a=asa (on behalf of drivers) for checkin to the 1.0 trunk

Comment 23

[Cavin Song]

Fix checked in.

Comment 24

[Ninoschka Baca]

Trunk build 2002-04-01: WinMe
Verified Fixed. 

- All cards and their content are imported
- The names of the lists are present but not the content as described in 
Comment#9.