827910 - Only report "extension" and "plugin" types for full add-on details

Status: VERIFIED FIXED

(Firefox Health Report Graveyard :: Client: Desktop, defect)

Description

[Gregory Szorc [:gps]]

Per bug 824528 comment #17.

Comment 1

[Gregory Szorc [:gps]]

Attachment: Only report subset of add-on types. v1

Comment 2

[Richard Newman [:rnewman]]

Comment on attachment 699358 [details] [diff] [review]
Only report subset of add-on types. v1

Review of attachment 699358 [details] [diff] [review]:
-----------------------------------------------------------------

::: services/healthreport/providers.jsm
@@ +727,5 @@
>      "onInstalled",
>      "onUninstalled",
>    ],
>  
> +  // Add-on types who full details are uploaded in the ActiveAddonsMeasurement.

s/who/for which

Comment 3

[Gregory Szorc [:gps]]

https://hg.mozilla.org/services/services-central/rev/3af96ef739db

Comment 4

[Gregory Szorc [:gps]]

Comment on attachment 699358 [details] [diff] [review]
Only report subset of add-on types. v1

[Approval Request Comment]
See uplift comment in bug 804745.

Comment 5

[Gregory Szorc [:gps]]

https://hg.mozilla.org/mozilla-central/rev/3af96ef739db

Comment 6

[Alex Keybl [:akeybl]]

Comment on attachment 699358 [details] [diff] [review]
Only report subset of add-on types. v1

https://bugzilla.mozilla.org/show_bug.cgi?id=804745#c37

Comment 7

[Scoobidiver (away)]

Pushed to Aurora:
http://hg.mozilla.org/releases/mozilla-aurora/rev/509fb1a9021b

Comment 8

[u279076]

What other types of add-ons are there? Is theme the only other type?

What sort of information should these other types store? No information or some subset?

Comment 9

[Gregory Szorc [:gps]]

The types of add-ons are: {theme, lwtheme (lightweight themes), plugin, extension}. Social providers are "service" and will soon be added. See https://docs.services.mozilla.com/healthreport/index.html#org-mozilla-addons-active for field details.

Comment 10

[u279076]

Thanks Gregory, after testing with some add-ons, plugins, and personas this appears to be working as expected; only plugins and add-ons have their full details reported.