Closed Bug 827910 Opened 7 years ago Closed 7 years ago

Only report "extension" and "plugin" types for full add-on details

Categories

(Firefox Health Report Graveyard :: Client: Desktop, defect)

defect
Not set

Tracking

(firefox20 fixed)

VERIFIED FIXED
Firefox 21
Tracking Status
firefox20 --- fixed

People

(Reporter: gps, Assigned: gps)

References

Details

Attachments

(1 file)

Assignee: nobody → gps
Status: NEW → ASSIGNED
Attachment #699358 - Flags: review?(rnewman)
Blocks: 718066
Attachment #699358 - Attachment description: Only report subset of add-on typs, v1 → Only report subset of add-on types. v1
Comment on attachment 699358 [details] [diff] [review]
Only report subset of add-on types. v1

Review of attachment 699358 [details] [diff] [review]:
-----------------------------------------------------------------

::: services/healthreport/providers.jsm
@@ +727,5 @@
>      "onInstalled",
>      "onUninstalled",
>    ],
>  
> +  // Add-on types who full details are uploaded in the ActiveAddonsMeasurement.

s/who/for which
Attachment #699358 - Flags: review?(rnewman) → review+
Comment on attachment 699358 [details] [diff] [review]
Only report subset of add-on types. v1

[Approval Request Comment]
See uplift comment in bug 804745.
Attachment #699358 - Flags: approval-mozilla-aurora?
https://hg.mozilla.org/mozilla-central/rev/3af96ef739db
Whiteboard: [fixed in services]
Target Milestone: --- → mozilla21
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Comment on attachment 699358 [details] [diff] [review]
Only report subset of add-on types. v1

https://bugzilla.mozilla.org/show_bug.cgi?id=804745#c37
Attachment #699358 - Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
What other types of add-ons are there? Is theme the only other type?

What sort of information should these other types store? No information or some subset?
The types of add-ons are: {theme, lwtheme (lightweight themes), plugin, extension}. Social providers are "service" and will soon be added. See https://docs.services.mozilla.com/healthreport/index.html#org-mozilla-addons-active for field details.
Thanks Gregory, after testing with some add-ons, plugins, and personas this appears to be working as expected; only plugins and add-ons have their full details reported.
Status: RESOLVED → VERIFIED
Component: Metrics and Firefox Health Report → Client: Desktop
Product: Mozilla Services → Firefox Health Report
Target Milestone: mozilla21 → Firefox 21
Product: Firefox Health Report → Firefox Health Report Graveyard
You need to log in before you can comment on or make changes to this bug.