82809 - bugzilla puts &#013; inside <pre> tags

Status: RESOLVED FIXED

(Bugzilla :: User Interface, defect, P2)

Description

[Chris Abbey]

I'm not sure if that's legal or not, but I do know that Konqueror can't cope 
with it as well as mozilla can. Now I know most folks around here don't care 
if another browser can handle the html we use or not, but when mozilla is 
falling apart and you're trying to report that fact in bugzilla, you need 
another browser to do it. Having line feeds encoded as html entities tends to 
make pre blocks an unholy mess, especially if they contain things like stack 
traces, or patches.

Comment 1

[Matthew Tuck [:CodeMachine]]

Bugzilla is a separate product from Mozilla, and we expect it to work on all
browsers as much as possible ... some of the team are involved very little or
not at all in Mozilla development.

Comment 2

[Dave Miller [:justdave]]

*** Bug 84292 has been marked as a duplicate of this bug. ***

Comment 3

[Jacob Steenhagen]

-> New Bugzilla Product

Comment 4

[Len Trigg]

FYI, the "links" text-based browser also doesn't like this encoding.

Comment 5

[Dave Miller [:justdave]]

Attachment: Patch to quoteUrls()

Comment 6

[Dave Miller [:justdave]]

The quoteUrls() routine, which all of the comments are passed through to add
hyperlinks before being displayed, calls value_quote() on the final comment
text, then does a s/
/\n/g on the results before passing it back.  Problem
is, several months back, value_quote() was changed to use 
 for line
endings instead of 
 because some browsers (most notably Netscape Mac) had
problems with 
 in hidden form values (which is the primary thing
value_quote() is used for).

The patch I just uploaded changes quoteUrls() to swap out 
 instead of 
.

Comment 7

[Dave Miller [:justdave]]

Comment on attachment 51829 [details] [diff] [review]
Patch to quoteUrls()

[03:44:28] <timeless> r=timeless for your change :-)
[03:44:33] <timeless> no second review needed [imo]

Comment 8

[Dave Miller [:justdave]]

checked in.