Closed
Bug 828099
Opened 11 years ago
Closed 11 years ago
upload a new talos.zip to capture fixes for android and windows counters
Categories
(Release Engineering :: General, defect)
Release Engineering
General
Tracking
(firefox19 fixed, firefox20 fixed, firefox21 fixed)
RESOLVED
FIXED
People
(Reporter: jmaher, Assigned: jmaher)
Details
Attachments
(1 file)
563 bytes,
patch
|
Callek
:
review+
akeybl
:
approval-mozilla-aurora+
akeybl
:
approval-mozilla-beta+
|
Details | Diff | Splinter Review |
we have a few talos fixes that need to land, specifically one for detecting processes under fennec. This is the new talos.zip: http://people.mozilla.org/~jmaher/taloszips/zips/talos.6de61e505cf3.zip
Assignee | ||
Comment 1•11 years ago
|
||
Please ensure that the file uploaded is the same size as the file on my people account. Also verify that the filename in this patch is available on the network before a r+
Attachment #699524 -
Flags: review?(bugspam.Callek)
Updated•11 years ago
|
Attachment #699524 -
Flags: review?(bugspam.Callek) → review+
Assignee | ||
Comment 2•11 years ago
|
||
what flags do I need in order to land this on aurora and beta?
Comment 3•11 years ago
|
||
Comment on attachment 699524 [details] [diff] [review] point talos.json to the newer talos.zip (1.0) [Approval Request Comment] Bug caused by (feature/regressing bug #): fennec org.mozilla.firefox.UpdateService User impact if declined: None Testing completed (on m-c, etc.): Tested on m-c Risk to taking this patch (and alternatives if risky): Without this approved, we cannot run succesful talos on beta, this patch avoids a false-positive in a basic test assertion from causing us to abort even trying to test. String or UUID changes made by this patch: None
Attachment #699524 -
Flags: approval-mozilla-beta?
Attachment #699524 -
Flags: approval-mozilla-aurora?
Comment 4•11 years ago
|
||
(In reply to Joel Maher (:jmaher) from comment #1) > Created attachment 699524 [details] [diff] [review] > point talos.json to the newer talos.zip (1.0) > > Please ensure that the file uploaded is the same size as the file on my > people account. Also verify that the filename in this patch is available on > the network before a r+ Perhaps from here on we should include the checksum and verify it as part of the process.
Assignee | ||
Comment 5•11 years ago
|
||
good idea.
Comment 6•11 years ago
|
||
...huh did I break us?
Assignee | ||
Comment 7•11 years ago
|
||
no, armen did last time we uploaded talos. it is working well. Just waiting on approval for aurora and beta, then this bug will be all done.
Updated•11 years ago
|
Attachment #699524 -
Flags: approval-mozilla-beta?
Attachment #699524 -
Flags: approval-mozilla-beta+
Attachment #699524 -
Flags: approval-mozilla-aurora?
Attachment #699524 -
Flags: approval-mozilla-aurora+
Comment 8•11 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/45ecce63e9f7
Assignee: nobody → jmaher
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Comment 9•11 years ago
|
||
Pushed to Beta and Aurora: http://hg.mozilla.org/releases/mozilla-beta/rev/859ccf9cb8f9 http://hg.mozilla.org/releases/mozilla-aurora/rev/3c86c34cac6b
Updated•11 years ago
|
Product: mozilla.org → Release Engineering
Updated•6 years ago
|
Component: General Automation → General
You need to log in
before you can comment on or make changes to this bug.
Description
•