Closed Bug 828101 Opened 11 years ago Closed 11 years ago

Initialize Firefox Health Report after session restore

Categories

(Firefox Health Report Graveyard :: Client: Desktop, defect)

defect
Not set
normal

Tracking

(firefox20 fixed)

RESOLVED FIXED
Firefox 21
Tracking Status
firefox20 --- fixed

People

(Reporter: gps, Assigned: gps)

References

Details

Attachments

(1 file)

For performance reasons, Vladan recommends we start Firefox Health Report after session restore, not final-ui-startup. This patch accomplishes this.

This will influence our metrics for session active/idle time since we may miss observers fired between app startup and session restore. We had that problem already. This just makes it worse. When we rewrite session code in bug 827157, we should come up with a more robust solution.
Attachment #699523 - Flags: review?(rnewman)
Depends on: 828152
Blocks: 828152
No longer depends on: 828152
Comment on attachment 699523 [details] [diff] [review]
Change observer notification, v1

Review of attachment 699523 [details] [diff] [review]:
-----------------------------------------------------------------

Seems formulaic. Is sessionstore-windows-restored sent when you opt *not* to restore a previous session?

https://developer.mozilla.org/en-US/docs/Observer_Notifications is ambiguous.

r+ conditional on that being true.
Attachment #699523 - Flags: review?(rnewman) → review+
If there is any interest, I can expose a promise that is resolved once session restore is complete.
(In reply to David Rajchenbach Teller [:Yoric] from comment #2)
> If there is any interest, I can expose a promise that is resolved once
> session restore is complete.

That would be interesting. But, we need something today that works. Is or is not the "sessionstore-windows-restored" event always fired?
(In reply to Gregory Szorc [:gps] from comment #3)
> That would be interesting. But, we need something today that works. Is or is
> not the "sessionstore-windows-restored" event always fired?

It's always fired, we rely on it in Telemetry ping http://mxr.mozilla.org/mozilla-central/source/toolkit/components/telemetry/TelemetryPing.js#1058
Comment on attachment 699523 [details] [diff] [review]
Change observer notification, v1

[Approval Request Comment]
See comment in bug 804745.
Attachment #699523 - Flags: approval-mozilla-aurora?
https://hg.mozilla.org/mozilla-central/rev/4f2cb2855aa1
Status: ASSIGNED → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Whiteboard: [fixed in services]
Target Milestone: --- → mozilla21
Comment on attachment 699523 [details] [diff] [review]
Change observer notification, v1

https://bugzilla.mozilla.org/show_bug.cgi?id=804745#c37
Attachment #699523 - Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
Component: Metrics and Firefox Health Report → Client: Desktop
Product: Mozilla Services → Firefox Health Report
Target Milestone: mozilla21 → Firefox 21
Product: Firefox Health Report → Firefox Health Report Graveyard
You need to log in before you can comment on or make changes to this bug.