828210 - Workaround bug 825622 in Gaia

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::Settings, defect, P2)

Description

[Anthony Ricaud (:rik)]

+++ This bug was initially created as a clone of Bug #825622 +++

STR:
 (can reproduce with: en-US, fr, pt-BR)
 - Tap Settings
 - Tap Device Information
 - Tap Legal information
 - Tap Open Source Notice

Seen:
 - Nothing happen, and a white screen show up after a short while.

Expected:
 - Start the browser app.


In this bug, we'll do a workaround in gaia while other people work on fixing the underlying bug 825622.

Comment 1

[Andrew Overholt [:overholt]]

Moving to Gaia.  FYI:  we previously had this as a blocker on the platform which is why the flag is still set here.

Comment 2

[Kan-Ru Chen [:kanru] (UTC+9)]

Currently it does show the "Open Source Licensing Information" page after a "long" while.

Do we really expect it to start the browser app?

Comment 3

[Tim Guan-tin Chien [:timdream] (please needinfo)]

(In reply to Anthony Ricaud (:rik) from comment #0)
> +++ This bug was initially created as a clone of Bug #825622 +++
> 

Please update the summary when you clone bugs.

What's the proposed workaround here? Launch Browser app instead?

Comment 4

[Kan-Ru Chen [:kanru] (UTC+9)]

According to the profile data, 96.% time is spent in layout::DoReflow

Comment 5

[Kan-Ru Chen [:kanru] (UTC+9)]

(In reply to Kan-Ru Chen [:kanru] from comment #4)
> According to the profile data, 96.% time is spent in layout::DoReflow

As said in bug 825622 :)

Comment 6

[Ben Francis [:benfrancis]]

(In reply to Tim Guan-tin Chien [:timdream] (MoCo-TPE) from comment #3)
> What's the proposed workaround here? Launch Browser app instead?

Would we have the same rendering issue inside a browser tab? Maybe we need to paginate the content somehow?

Comment 7

[Anthony Ricaud (:rik)]

My current workaround is to use an empty iframe and set the src after we transitioned and remove it when we leave the panel.

I'm also trying alternatives to remove the setTimeout() logic of panel switching but so far, it regresses the animation the first time we open a panel.

Comment 8

[Vivien Nicolas (:vingtetun) (:21) - (NOT reading bugmails, needinfo? please)]

(In reply to Anthony Ricaud (:rik) from comment #7)
> My current workaround is to use an empty iframe and set the src after we
> transitioned and remove it when we leave the panel.
> 
> I'm also trying alternatives to remove the setTimeout() logic of panel
> switching but so far, it regresses the animation the first time we open a
> panel.

The regression of the animation is really not important imo... Having an application that works without having to kill it is way more important.

Comment 9

[Gervase Markham [:gerv]]

Not sure if anyone's considering this, but from a legal perspective, loading this page off the network rather than having it stored locally is a no-no. Just wanted to mention it :-)

Gerv

Comment 10

[Anthony Ricaud (:rik)]

Attachment: Review pointer to https://github.com/mozilla-b2g/gaia/pull/7455

Comment 11

[Fabien Cazenave [:kaze]]

https://github.com/mozilla-b2g/gaia/commit/4a5c0d07717b9fc53581c2335d8e65576d790360