828247 - Library downloads view does not show the end time for completed downloads

Status: VERIFIED FIXED

(Firefox :: Downloads Panel, defect)

Description

[Asaf Romano (gone)]

Library downloads view does not show the end time for completed downloads.

There are two problems here:
1) There's a bug in getStatusText that ignores the end time for session downloads. That's easy to fix.
2) We don't have the end time for past downloads, only the start time. I've no idea what we can do about this.

Comment 1

[Marco Bonardo [:mak]]

(In reply to Mano from comment #0)
> 2) We don't have the end time for past downloads, only the start time. I've
> no idea what we can do about this.

use the file last modified time?

Comment 2

[Asaf Romano (gone)]

Unfortunately sometimes people edit those .doc files they download. I think we'll just have to use the visit date for downloads done in past releases.

Comment 3

[Marco Bonardo [:mak]]

(In reply to Mano from comment #2)
> Unfortunately sometimes people edit those .doc files they download. I think
> we'll just have to use the visit date for downloads done in past releases.

fine, none of the solutions is perfect, so no strong feelings.

Comment 4

[Marco Bonardo [:mak]]

I may look at this, we'll just have to hook up endTime once we have it.

Comment 5

[Marco Bonardo [:mak]]

Attachment: patch v1.0

Comment 6

[Marco Bonardo [:mak]]

Attachment: patch v1.1

Comment 7

[Marco Bonardo [:mak]]

don't need the dependency to fix this, they can be parallel

Comment 8

[Marco Bonardo [:mak]]

Attachment: patch v1.2

Always use shortDate per IRC discussion (I'm going to file bug to find the time threashold in future)
fix missing breaks; in the switch!

Comment 9

[Asaf Romano (gone)]

Comment on attachment 700710 [details] [diff] [review]
patch v1.2

Review of attachment 700710 [details] [diff] [review]:
-----------------------------------------------------------------

As a temporary solution, this is fine.

::: browser/components/downloads/content/allDownloadsViewOverlay.js
@@ +360,5 @@
>      }
>  
> +    // This is a not-in-progress or history download.
> +
> +    let stateLabel = ""

nit #1: missing semicolon. nit #2: remove the empty line.

Comment 10

[Marco Bonardo [:mak]]

Attachment: patch v1.3

Comment 11

[Marco Bonardo [:mak]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/0481a14279d3

Comment 12

[Marco Bonardo [:mak]]

Comment on attachment 700718 [details] [diff] [review]
patch v1.3

[Approval Request Comment]
Bug caused by (feature/regressing bug #): Downloads panel feature
User impact if declined: incomplete ui
Testing completed (on m-c, etc.): m-i (merge pending)
Risk to taking this patch (and alternatives if risky): limited to the feature
String or UUID changes made by this patch: none

Comment 13

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/0481a14279d3

Comment 14

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/0481a14279d3

Comment 15

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/0481a14279d3

Comment 16

[Marco Bonardo [:mak]]

https://hg.mozilla.org/releases/mozilla-aurora/rev/ccb73a00491f

Comment 17

[Simona Badau, Desktop QA]

Verified as fixed on the latest Nightly and Aurora - the end time for completed downloads is now displayed in the Library Downloads View.

Verified on Windows 7, Ubuntu 12.04 and Mac OS X 10.8:
Mozilla/5.0 (Windows NT 6.1; rv:21.0) Gecko/20130128 Firefox/21.0 Build ID:20130128030943
Mozilla/5.0 (Windows NT 6.1; rv:20.0) Gecko/20130128 Firefox/20.0 Build ID:20130128042018	

Mozilla/5.0 (X11; Linux i686; rv:21.0) Gecko/20130128 Firefox/21.0 Build ID:20130128030943
Mozilla/5.0 (X11; Linux i686; rv:20.0) Gecko/20130123 Firefox/20.0 Build ID:20130128042018

Mozilla/5.0 (Macintosh; Intel Mac OS X 10.8; rv:21.0) Gecko/20130128 Firefox/21.0	Build ID:20130128030943
Mozilla/5.0 (Macintosh; Intel Mac OS X 10.8; rv:20.0) Gecko/20130128 Firefox/20.0	Build ID:20130128042018