828249 - Fixed position elements are incorrectly placed when zooming out beyond the page boundaries

Status: RESOLVED FIXED

(Firefox for Android Graveyard :: Toolbar, defect)

Description

[Chris Lord [:cwiiis]]

I don't know when this happened but someone mixed up the width and height fields in the fixed-position transform code in CompositorParent. Patch incoming. Will also check how far back this goes, this would definitely be a candidate for merging to aurora/beta if those are affected.

Comment 1

[Chris Lord [:cwiiis]]

Attachment: Correct fixed layer positioning when zoomed out beyond page bounds

This applies on top of the patch in bug 827844 but is easily rebased.

Comment 2

[Chris Lord [:cwiiis]]

Affects nightly and aurora but not beta. At some point a Point type was changed to a Size type and width/height were mixed around.

Comment 3

[Kartikaya Gupta (email:[e-mail])]

Comment on attachment 699704 [details] [diff] [review]
Correct fixed layer positioning when zoomed out beyond page bounds

Review of attachment 699704 [details] [diff] [review]:
-----------------------------------------------------------------

This will need to be uplifted to aurora (and maybe b2g?), it was regressed by bug 811950 recently. Patch looks good.

Comment 4

[Kartikaya Gupta (email:[e-mail])]

CC'ing anthony who can advise on whether or not this patch needs to go into b2g.

Comment 5

[Chris Lord [:cwiiis]]

(In reply to Kartikaya Gupta (email:[e-mail]) from comment #4)
> CC'ing anthony who can advise on whether or not this patch needs to go into
> b2g.

b2g doesn't have overscroll, so the x and y scale will never differ - shouldn't be necessary.

Comment 6

[Kartikaya Gupta (email:[e-mail])]

Yeah but we might want to uplift anyway to keep code in sync and avoid rebasing future patches that do need uplift.

Comment 7

[Chris Lord [:cwiiis]]

Pushed to inbound:

https://hg.mozilla.org/integration/mozilla-inbound/rev/934e8b48a539

Comment 8

[Chris Lord [:cwiiis]]

Comment on attachment 699704 [details] [diff] [review]
Correct fixed layer positioning when zoomed out beyond page bounds

[Approval Request Comment]
Bug caused by (feature/regressing bug #): Fixed position elements float in weird places when zooming out beyond page bounds, regressed by bug #811950
User impact if declined: The above
Testing completed (on m-c, etc.): Tested locally and patch on inbound. Has green try run.
Risk to taking this patch (and alternatives if risky): Trivial fix, no appreciable risk.
String or UUID changes made by this patch: None.

Comment 9

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/934e8b48a539

Comment 10

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/934e8b48a539

Comment 11

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/934e8b48a539

Comment 12

[Alex Keybl [:akeybl]]

Comment on attachment 699704 [details] [diff] [review]
Correct fixed layer positioning when zoomed out beyond page bounds

Low risk fix for Firefox 20 zoom/layout regression. Approving for Aurora 20.

Comment 13

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-aurora/rev/3e7b5800b2d5