Closed Bug 828277 Opened 12 years ago Closed 12 years ago

[FTU] Change newsletterID in the Basket client

Categories

(Firefox OS Graveyard :: Gaia::First Time Experience, defect)

Product:
Firefox OS Graveyard
Component:
Gaia::First Time Experience
Platform:
x86
macOS
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(blocking-basecamp:-, b2g18+ fixed, b2g18-v1.0.0 affected, b2g18-v1.0.1 fixed)

Status:
RESOLVED FIXED
Project Flags:
blocking-basecamp -
Tracking Flags:
Tracking Status
b2g18 + fixed
b2g18-v1.0.0 --- affected
b2g18-v1.0.1 --- fixed

People

(Reporter: mbudzynski, Assigned: fcampo)

References

Details

Attachments

(1 file)

link to https://github.com/mozilla-b2g/gaia/pull/7813
245 bytes, text/html
mbudzynski
: review+
lsblakk
: approval-gaia-v1+
Details
On the last screen of FTU, where user needs to provide email address, we use fake newsletterID to send the data to. We should use our own FirefoxOS newsletter.
blocking-basecamp: --- → ?
We would take a patch for this. Just ask for approval.
blocking-basecamp: ? → -
tracking-b2g18: --- → +
The newsletter has been added to the basket service. The ID to use is "firefox-os". Please ping me with questions.
Attachment #706780 - Flags: review?(mbudzynski)
Assignee: nobody → fernando.campo
Attachment #706780 - Flags: review?(mbudzynski) → review+
r=me, thanks.
Comment on attachment 706780 [details] link to https://github.com/mozilla-b2g/gaia/pull/7813 NOTE: If blocking-basecamp+ is set, just land it for now. [Approval Request Comment] Bug caused by (feature/regressing bug #): User impact if declined: high. user will not be able to subscribe to newsletter, as the current url is fake Testing completed: Risk to taking this patch (and alternatives if risky):
Attachment #706780 - Flags: approval-gaia-v1?
sorry forgot the risk: low, we only change the url
Comment on attachment 706780 [details] link to https://github.com/mozilla-b2g/gaia/pull/7813 Approved for uplift to v1-train and v1.0.0
Attachment #706780 - Flags: approval-gaia-v1? → approval-gaia-v1+
Please make sure to land on master as well :)
Merged on master https://github.com/mozilla-b2g/gaia/commit/b8ea0e24c35bc81f7289596a1ae8bd40ba1f1bd5
Status: NEW → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
v1-train: bc49f5da787db3f775a02fab9e57874127fa8c45 This is listed as v1.0.0 affected, but doesn't have tef+. Not sure what to do there...
status-b2g18-v1.0.0: affected → fixed
(In reply to Lukas Blakk [:lsblakk] from comment #7) > Comment on attachment 706780 [details] > link to https://github.com/mozilla-b2g/gaia/pull/7813 > > Approved for uplift to v1-train and v1.0.0 Did you mean to set tef+?
Batch edit: Bugs fixed on b2g18 after 1/25 merge to v1.0 branch are fixed on v1.0.1 branch.
status-b2g18-v1.0.1: --- → fixed
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: