828488 - Properly set the "active" attribute for session downloads

Status: RESOLVED FIXED

(Firefox :: Downloads Panel, defect)

Description

[Marco Bonardo [:mak] (Away July 4-13)]

The session downloads don't get the attribute and lack the binding.

Comment 1

[Marco Bonardo [:mak] (Away July 4-13)]

Attachment: patch v1.0

Comment 2

[Marco Bonardo [:mak] (Away July 4-13)]

Attachment: patch v1.1

better, per IRC discussion

Comment 3

[Marco Bonardo [:mak] (Away July 4-13)]

Attachment: patch v1.2

even better!

Comment 4

[Marco Bonardo [:mak] (Away July 4-13)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/f081e37be228

Comment 5

[Marco Bonardo [:mak] (Away July 4-13)]

cherry-picked the inbound patch to central, just to ensure it will make the next nightly.
there should be no problem on merge since they are identical.
https://hg.mozilla.org/mozilla-central/rev/f60b87eed1ac

Comment 6

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/f081e37be228

Comment 7

[Marco Bonardo [:mak] (Away July 4-13)]

Comment on attachment 699921 [details] [diff] [review]
patch v1.2

[Approval Request Comment]
Bug caused by (feature/regressing bug #): Downloads panel feature
User impact if declined: Incomplete UI
Testing completed (on m-c, etc.): m-c
Risk to taking this patch (and alternatives if risky): Limited to the feature
String or UUID changes made by this patch: none

Comment 8

[Marco Bonardo [:mak] (Away July 4-13)]

https://hg.mozilla.org/releases/mozilla-aurora/rev/2bdd85edca10

Comment 9

[Mihai Morar, (:MihaiMorar)]

How can QA verify this fix?