828532 - Remove "prototype" as reserved identifier in WebIDL

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, defect)

Description

[William Chen [:wchen]]

"prototype" is no longer a reserved identifier.

Comment 1

[William Chen [:wchen]]

Attachment: Remove "prototype" as reserved identifier in WebIDL

Comment 2

[Boris Zbarsky [:bzbarsky]]

This needs a webidl parser test or three.  In particular, don't we need to still forbid this in the cases where it's not allowed?  Specifically it can't be the name of a constant, static attribute, or static operation.  Do we enforce that anywhere after this change?

We should add tests for those, as well as the fact that dictionary members and non-static attributes and operations named prototype all parse successfully.

Comment 3

[William Chen [:wchen]]

I missed those cases when reading the new spec. No, it's currently not handled right now. I'll work on a new patch.

Comment 4

[William Chen [:wchen]]

Attachment: Removed prototype as a reserved identifier in WebIDL.

Comment 5

[William Chen [:wchen]]

Attachment: Removed prototype as a reserved identifier in WebIDL.

Comment 6

[Boris Zbarsky [:bzbarsky]]

Comment on attachment 700535 [details] [diff] [review]
Removed prototype as a reserved identifier in WebIDL.

>+    parser.reset()

That should be:

  parser = parser.reset();

I tend to print the actual exceptions in your except blocks when writing these tests so I can make sure the exception is being thrown for the right reasons, then remove the prints when finishing up the patch....  We need a better setup for this.  :(

Please add parser tests, not just TestCodeGen.webidl for being able to parse attributes/dictionaries/operations named 'prototype'.

Did you run the TestCodeGen test?  I'm a little surprised it passed as-is, since you didn't actually define C++ stuff for TestNonReservedAttribute and TestNonReservedOperation.  Probably simpler to just take those interfaces out.

r=me with all that.

Comment 7

[William Chen [:wchen]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/e7ee10b0e303

Comment 8

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/e7ee10b0e303

Comment 9

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/e7ee10b0e303

Comment 10

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/e7ee10b0e303