Closed
Bug 828607
Opened 11 years ago
Closed 11 years ago
GC: Fix exact rooting in jsproxy.cpp
Categories
(Core :: JavaScript Engine, defect)
Core
JavaScript Engine
Tracking
()
RESOLVED
FIXED
mozilla21
People
(Reporter: terrence, Assigned: terrence)
References
Details
Attachments
(1 file)
8.55 KB,
patch
|
evilpie
:
review+
|
Details | Diff | Splinter Review |
We were using the direct arg rather than the internally rooted arg in a few places.
Attachment #699978 -
Flags: review?(evilpies)
Comment 1•11 years ago
|
||
Comment on attachment 699978 [details] [diff] [review] v0: trivial Review of attachment 699978 [details] [diff] [review]: ----------------------------------------------------------------- I als noticed the has and hasOwn ones while writing my patch. I blame the rest on the compiler not being able to help without them being Handle<>. What do you think about proxy_Call and proxy_Construct?
Attachment #699978 -
Flags: review?(evilpies) → review+
Assignee | ||
Comment 2•11 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/c3268996719e
Comment 3•11 years ago
|
||
Backed out for burning: https://tbpl.mozilla.org/?tree=Mozilla-Inbound&rev=c3268996719e https://hg.mozilla.org/integration/mozilla-inbound/rev/e3f554b113a0 "v0: trivial" hehe :-)
Assignee | ||
Comment 4•11 years ago
|
||
Sorry for the burning. Hit an over-zealous assertion that depends on how the code gets compiled, which wasn't hitting me. Green try run at: https://tbpl.mozilla.org/?tree=Try&rev=f47ccfb463bc Pushed at: https://hg.mozilla.org/integration/mozilla-inbound/rev/71d3013257a9
Comment 5•11 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/71d3013257a9
Status: ASSIGNED → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla21
Comment 6•11 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/71d3013257a9
Comment 7•11 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/71d3013257a9
You need to log in
before you can comment on or make changes to this bug.
Description
•