Closed Bug 828607 Opened 7 years ago Closed 7 years ago

GC: Fix exact rooting in jsproxy.cpp

Categories

(Core :: JavaScript Engine, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
mozilla21

People

(Reporter: terrence, Assigned: terrence)

References

Details

Attachments

(1 file)

Attached patch v0: trivialSplinter Review
We were using the direct arg rather than the internally rooted arg in a few places.
Attachment #699978 - Flags: review?(evilpies)
Comment on attachment 699978 [details] [diff] [review]
v0: trivial

Review of attachment 699978 [details] [diff] [review]:
-----------------------------------------------------------------

I als noticed the has and hasOwn ones while writing my patch. I blame the rest on the compiler not being able to help without them being Handle<>. What do you think about proxy_Call and proxy_Construct?
Attachment #699978 - Flags: review?(evilpies) → review+
Sorry for the burning. Hit an over-zealous assertion that depends on how the code gets compiled, which wasn't hitting me.

Green try run at:
https://tbpl.mozilla.org/?tree=Try&rev=f47ccfb463bc

Pushed at:
https://hg.mozilla.org/integration/mozilla-inbound/rev/71d3013257a9
https://hg.mozilla.org/mozilla-central/rev/71d3013257a9
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla21
You need to log in before you can comment on or make changes to this bug.