828607 - GC: Fix exact rooting in jsproxy.cpp

Status: RESOLVED FIXED

(Core :: JavaScript Engine, defect)

Description

[Terrence Cole [:terrence]]

Attachment: v0: trivial

We were using the direct arg rather than the internally rooted arg in a few places.

Comment 1

[Tom S. (please needinfo tschuster)]

Comment on attachment 699978 [details] [diff] [review]
v0: trivial

Review of attachment 699978 [details] [diff] [review]:
-----------------------------------------------------------------

I als noticed the has and hasOwn ones while writing my patch. I blame the rest on the compiler not being able to help without them being Handle<>. What do you think about proxy_Call and proxy_Construct?

Comment 2

[Terrence Cole [:terrence]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/c3268996719e

Comment 3

[Ed Morley [:emorley]]

Backed out for burning:
https://tbpl.mozilla.org/?tree=Mozilla-Inbound&rev=c3268996719e

https://hg.mozilla.org/integration/mozilla-inbound/rev/e3f554b113a0

"v0: trivial" hehe :-)

Comment 4

[Terrence Cole [:terrence]]

Sorry for the burning. Hit an over-zealous assertion that depends on how the code gets compiled, which wasn't hitting me.

Green try run at:
https://tbpl.mozilla.org/?tree=Try&rev=f47ccfb463bc

Pushed at:
https://hg.mozilla.org/integration/mozilla-inbound/rev/71d3013257a9

Comment 5

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/71d3013257a9

Comment 6

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/71d3013257a9

Comment 7

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/71d3013257a9