828625 - unthrottle FF18.0 for 10am PST Thurs Jan 10, 2013

Status: VERIFIED FIXED

(Release Engineering :: Release Requests, defect)

Description

[Kim Moir [:kmoir] ET]

Talked to bajaj in #release-drivers and she said they were targeting 10am PST tomorrow.

Comment 1

[Kim Moir [:kmoir] ET]

Attachment: patch

Comment 2

[[e-mail] (:bhearsum)]

Comment on attachment 700000 [details] [diff] [review]
patch

Review of attachment 700000 [details] [diff] [review]:
-----------------------------------------------------------------

::: inc/config-dist.php
@@ -95,4 @@
>  //    )
>  // );
>  //
> -$productThrottling = array(

This list should be emptied out rather than deleted altogether. Looks fine otherwise.

Comment 3

[Kim Moir [:kmoir] ET]

If you look at line 85 of config-dist.php there's already a 

$productThrottling = array(
);

I think my previous patch was wrong add a new $productThrottling definition but it worked since it superceded the first definition.  Thus this patch is okay.

Comment 4

[[e-mail] (:bhearsum)]

(In reply to Kim Moir [:kmoir] from comment #3)
> If you look at line 85 of config-dist.php there's already a 
> 
> $productThrottling = array(
> );
> 
> I think my previous patch was wrong add a new $productThrottling definition
> but it worked since it superceded the first definition.  Thus this patch is
> okay.

That's the commented out one, isn't it?

Comment 5

[Nick Thomas [:nthomas] (UTC+12)]

(In reply to Kim Moir [:kmoir] from comment #3)
> I think my previous patch was wrong add a new $productThrottling definition
> but it worked since it superceded the first definition.  Thus this patch is
> okay.

This explanation looks correct to me, as we lost the example in a comment in an earlier confusion. Lets try to avoid two declarations next time.

Comment 6

[Kim Moir [:kmoir] ET]

Yes :-) Line 85 isn't commented out, but isn't reflected in the patch.

Comment 7

[Justin Dolske [:Dolske]]

(In reply to Kim Moir [:kmoir] from comment #1)
> Created attachment 700000 [details] [diff] [review]
> patch

Congratulations on attachment 700000 [details] [diff] [review]! And, uhh, your r-. :D

Comment 8

[[e-mail] (:bhearsum)]

Comment on attachment 700000 [details] [diff] [review]
patch

Ah, I see now. Sorry about that - it's clear to me now after looking at the current, full state, of the file.

Comment 9

[u279076]

Verified fixed using the following builds...

Windows 7:
----------
16.0.2 en-US -> 18.0 en-US partial
17.0 de -> 18.0 de complete+fallback

Mac OSX 10.7:
-------------
15.0.1 es-ES -> 18.0 es-ES partial+fallback
16.0 en-US -> 18.0 en-US complete

Ubuntu 12.04:
-------------
17.0 en-US -> 18.0 en-US complete
16.0.2 fr -> 18.0 fr partial+fallback 

In all cases a background update was found, downloaded, and applied successfully.