Automatically try to use the 4.6 toolchain on android

RESOLVED FIXED in mozilla21

Status

()

Core
Build Config
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: kats, Assigned: kats)

Tracking

21 Branch
mozilla21
All
Android
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

The build/autoconf/android.m4 file defaults to using 4.4.3 as the android_gnu_compiler_version. As all the android builds are now on NDK r8c and using gcc-4.6, we should change this to 4.6 and provide fallback to 4.4.3 for users who have not yet upgraded their NDKs.
Created attachment 701330 [details] [diff] [review]
Loop through various toolchain possibilities to find one

This will obey with-android-gnu-compiler-version if it is set, and fail if it is set and wrong. If it is not set, it will try 4.6 and 4.4.3 (in that order) and pick the first that is found.

I tested the various combinations locally, and also pushed to try at https://tbpl.mozilla.org/?tree=Try&rev=49900f089284
Attachment #701330 - Flags: review?(mh+mozilla)
Attachment #701330 - Flags: review?(mh+mozilla) → review+
https://hg.mozilla.org/integration/mozilla-inbound/rev/a712a8e5434f

Comment 3

5 years ago
https://hg.mozilla.org/mozilla-central/rev/a712a8e5434f
Status: NEW → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla21
You need to log in before you can comment on or make changes to this bug.