828690 - GC: Return Unrooted from StringBuffer::finish

Status: RESOLVED FIXED

(Core :: JavaScript Engine, defect)

Description

[Terrence Cole [:terrence]]

Attachment: v0

This is causing us problems right now. I want to think about what to do with setGuessedAtom's parameters a bit more before changing them.

Comment 1

[Terrence Cole [:terrence]]

Attachment: v1

Okay, it turns out the prior patch totally messed up JSAtom's namespace exposure. The real solution turns out to be a bit annoying. We will need to revisit the hunk in jsprvtd.h.

Comment 2

[Terrence Cole [:terrence]]

Comment on attachment 700080 [details] [diff] [review]
v1

Whoops, I meant to flag Bill for review on this.

Comment 3

[Bill McCloskey [inactive unless it's an emergency] (:billm)]

Comment on attachment 700080 [details] [diff] [review]
v1

Review of attachment 700080 [details] [diff] [review]:
-----------------------------------------------------------------

::: js/src/jsprvtd.h
@@ +201,5 @@
>  typedef JSAtom *                       RawAtom;
> +#ifdef DEBUG
> +typedef JSAtom *                       UnrootedAtom;
> +#else
> +typedef Unrooted<JSAtom*>              UnrootedAtom;

As we discussed, can you just use the normal ForwardDeclareJS(Atom) for these (and not put them in jsprvtd.h)?

Comment 4

[Terrence Cole [:terrence]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/a91d0b7558d8

Comment 5

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/a91d0b7558d8