Closed Bug 828703 Opened 7 years ago Closed 7 years ago

Incorrect idle-daily removeObserver in HealthReporter.jsm

Categories

(Firefox Health Report Graveyard :: Client: Desktop, defect)

defect
Not set

Tracking

(firefox19 unaffected, firefox20 fixed, firefox21 fixed)

RESOLVED FIXED
Firefox 21
Tracking Status
firefox19 --- unaffected
firefox20 --- fixed
firefox21 --- fixed

People

(Reporter: gps, Assigned: gps)

References

Details

Attachments

(1 file)

We set _initialized = false and then check _initialized later in the same function. Obvious logic flaw. Patch is trivial.
Blocks: 829887
No longer blocks: 718066
Trivial fix.
Assignee: nobody → gps
Status: NEW → ASSIGNED
Attachment #702510 - Flags: review?(rnewman)
Comment on attachment 702510 [details] [diff] [review]
Properly remove observer, v1

Review of attachment 702510 [details] [diff] [review]:
-----------------------------------------------------------------

Sure, why not.
Attachment #702510 - Flags: review?(rnewman) → review+
Comment on attachment 702510 [details] [diff] [review]
Properly remove observer, v1

[Approval Request Comment]

Trivial FHR patch to improve rigor. Requesting uplift so trees are in sync.
Attachment #702510 - Flags: approval-mozilla-aurora?
triage drive-by, waiting for landing to mozilla-central before approving to aurora.
https://hg.mozilla.org/mozilla-central/rev/83c4119dbbb1
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Whiteboard: [fixed in services]
Target Milestone: --- → mozilla21
Attachment #702510 - Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
Component: Metrics and Firefox Health Report → Client: Desktop
Product: Mozilla Services → Firefox Health Report
Target Milestone: mozilla21 → Firefox 21
Product: Firefox Health Report → Firefox Health Report Graveyard
You need to log in before you can comment on or make changes to this bug.