Closed
Bug 828703
Opened 11 years ago
Closed 11 years ago
Incorrect idle-daily removeObserver in HealthReporter.jsm
Categories
(Firefox Health Report Graveyard :: Client: Desktop, defect)
Firefox Health Report Graveyard
Client: Desktop
Tracking
(firefox19 unaffected, firefox20 fixed, firefox21 fixed)
RESOLVED
FIXED
Firefox 21
Tracking | Status | |
---|---|---|
firefox19 | --- | unaffected |
firefox20 | --- | fixed |
firefox21 | --- | fixed |
People
(Reporter: gps, Assigned: gps)
References
Details
Attachments
(1 file)
1.05 KB,
patch
|
rnewman
:
review+
bajaj
:
approval-mozilla-aurora+
|
Details | Diff | Splinter Review |
We set _initialized = false and then check _initialized later in the same function. Obvious logic flaw. Patch is trivial.
Assignee | ||
Updated•11 years ago
|
Assignee | ||
Comment 1•11 years ago
|
||
Trivial fix.
Comment 2•11 years ago
|
||
Comment on attachment 702510 [details] [diff] [review] Properly remove observer, v1 Review of attachment 702510 [details] [diff] [review]: ----------------------------------------------------------------- Sure, why not.
Attachment #702510 -
Flags: review?(rnewman) → review+
Assignee | ||
Comment 3•11 years ago
|
||
https://hg.mozilla.org/services/services-central/rev/83c4119dbbb1
Whiteboard: [fixed in services]
Assignee | ||
Updated•11 years ago
|
status-firefox19:
--- → unaffected
status-firefox20:
--- → affected
status-firefox21:
--- → affected
Assignee | ||
Comment 4•11 years ago
|
||
Comment on attachment 702510 [details] [diff] [review] Properly remove observer, v1 [Approval Request Comment] Trivial FHR patch to improve rigor. Requesting uplift so trees are in sync.
Attachment #702510 -
Flags: approval-mozilla-aurora?
Comment 5•11 years ago
|
||
triage drive-by, waiting for landing to mozilla-central before approving to aurora.
Assignee | ||
Comment 6•11 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/83c4119dbbb1
Status: ASSIGNED → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Whiteboard: [fixed in services]
Target Milestone: --- → mozilla21
Updated•11 years ago
|
Attachment #702510 -
Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
Comment 7•11 years ago
|
||
Pushed to Aurora: http://hg.mozilla.org/releases/mozilla-aurora/rev/0836a971d926
Updated•11 years ago
|
Component: Metrics and Firefox Health Report → Client: Desktop
Product: Mozilla Services → Firefox Health Report
Target Milestone: mozilla21 → Firefox 21
Updated•6 years ago
|
Product: Firefox Health Report → Firefox Health Report Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•