Closed Bug 828737 Opened 12 years ago Closed 12 years ago

Auto-update hosted app names

Categories

(Marketplace Graveyard :: General, defect)

defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED
2013-01-24

People

(Reporter: robhudson, Assigned: robhudson)

References

Details

(Whiteboard: u=dev p=3)

Along with our cron that updates hosted app manifests we should track app name changes and update the app name in our db to match. This currently triggers a re-review so we're good there.
Assignee: nobody → robhudson.mozbugs
Target Milestone: --- → 2013-01-10
Also invalid. See bug 826555 for context.

We aren't allowing app updates to rename an app for v1.
Status: NEW → RESOLVED
Closed: 12 years ago
Resolution: --- → INVALID
(In reply to Jason Smith [:jsmith] from comment #1)
> Also invalid. See bug 826555 for context.

I realize bug 826555 will not allow updates to rename the app, but we also need to consider new installs and honor the current name as it is in the manifest. This bug is about keeping the Marketplace data in sync with the app manifest, regardless of if it breaks updates or not.
Status: RESOLVED → REOPENED
Resolution: INVALID → ---
Didn't quite make it, but it's close... bumping to next week's milestone.
Target Milestone: 2013-01-10 → 2013-01-17
Latest code branch is here:
https://github.com/robhudson/zamboni/tree/828737-hosted-app-name-updates

I'm bumping to next week but hope to push early Monday after some review.
Target Milestone: 2013-01-17 → 2013-01-24
Whiteboard: u=dev p=3
https://github.com/mozilla/zamboni/commit/a0084e9 

For QA, the easiest is to set up a manifest at http://testmanifest.com/. Then try adding/updating/removing variations of the manifest name, the default_locale, the "names" inside "locales" and check the reviewer tools for proper logging of the changes.

An example:

Before:

{
  "name": "Socks",
  "description":"This app has been automatically generated by testmanifest.com",
  "version":"1.0",
  "icons":{
    "16":"http://testmanifest.com/icon-16.png",
    "48":"http://testmanifest.com/icon-48.png",
    "128":"http://testmanifest.com/icon-128.png"
  },
  "installs_allowed_from":[
    "*"
  ],
  "developer":{
    "name":"Gregory Koberger",
    "url":"http://gkoberger.net"
  }
}

After:

{
  "name": "Socks App",
  "default_locale": "en-US",
  "description":"This app has been automatically generated by testmanifest.com",
  "version":"1.0",
  "icons":{
    "16":"http://testmanifest.com/icon-16.png",
    "48":"http://testmanifest.com/icon-48.png",
    "128":"http://testmanifest.com/icon-128.png"
  },
  "installs_allowed_from":[
    "*"
  ],
  "developer":{
    "name":"Gregory Koberger",
    "url":"http://gkoberger.net"
  },
  "locales": {
    "es": {
      "name": "Eso si que es"
    }
  }
}

Should show something like:

Manifest name changed from "Socks" to "Socks App".
Locales added: "Eso si que es" (es).
Locales updated: "Socks" -> "Socks App" (en-US).
Status: REOPENED → RESOLVED
Closed: 12 years ago12 years ago
Resolution: --- → FIXED
I noticed this in the re-review queue:
https://marketplace.firefox.com//reviewers/apps/review/faletransito
- note its name is missing on Marketplace but has one in the manifest.  Something isn't fully working.
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
Closing again. The real culprit was bug 835407.
Status: REOPENED → RESOLVED
Closed: 12 years ago12 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.