828795 - Add identical paint flashing

Status: RESOLVED WONTFIX

(Core :: Graphics, defect)

Description

[Benoit Girard (:BenWa)]

Similar to paint flashing but draw in a 'magic color' (default to say red) any pixel we draw that is identical to the previous.

We draw to an empty surface), compare the result, draw the surface to dest and flash red identical pixels.

Comment 1

[Jet Villegas (inactive)]

I like it :)

I'd also like to see the bounding invalidation rect flashed with a 1px red border when the before/after contents are 100% identical.

Comment 2

[Benoit Girard (:BenWa)]

Attachment: WIP

There's a striding issue that needs to be fixed.

Comment 3

[Benoit Girard (:BenWa)]

Attachment: WIP v2

I made more progress on this but found a big problem. Sometimes we compare against an un-initialized surface which causes garbage identical flashing. I need to find an easy way to differentiate between un-initialized memory and a previous paint but I don't know ATM.

Comment 4

[Paul Rouget [:paul]]

Can someone explain how this would be useful compared to the current paint flashing mechanism?

Comment 5

[Benoit Girard (:BenWa)]

It's make it easier to see when we spend time painting the exact same pixel instead of showing where we paint. QuartzDebug had a similar tool that was very useful but with our changes in platform it no longer works.

Comment 6

[Gregory Pappas [:gregp]]

Paint flashing is gone
this patch is too old to salvage