828835 - Firefox OS cannot start up due to an exception: NS_ERROR_FILE_TARGET_DOES_NOT_EXIST

Status: VERIFIED FIXED

(Firefox OS Graveyard :: General, defect)

Description

[Gene Lian (I already quit Mozilla)]

STR
==============================
  0. 2013/1/10 m-c build.
  1. Cannot start up after reflashing everything.

LOG
==============================
E/GeckoConsole(  105): [JavaScript Error: "DOMApplicationRegistry: Could not parse JSON: /data/local/webapps/webapps.json [Exception... "Component returned failure code: 0x80520006 (NS_ERROR_FILE_TARGET_DOES_NOT_EXIST) [nsIFile.copyTo]"  nsresult: "0x80520006 (NS_ERROR_FILE_TARGET_DOES_NOT_EXIST)"  location: "JS frame :: resource://gre/modules/Webapps.jsm :: installPreinstalledApp/< :: line 243"  data: no]
E/GeckoConsole(  105): [JavaScript Error: "[Exception... "Component returned failure code: 0x80520006 (NS_ERROR_FILE_TARGET_DOES_NOT_EXIST) [nsIFile.copyTo]"  nsresult: "0x80520006 (NS_ERROR_FILE_TARGET_DOES_NOT_EXIST)"  location: "JS frame :: resource://gre/modules/Webapps.jsm :: installPreinstalledApp/< :: line 243"  data: no]" {file: "resource://gre/modules/Webapps.jsm" line: 243}]
E/GeckoConsole(  105): [JavaScript Error: "NO SETTINGS PERMISSION FOR: app://system.gaiamobile.org
E/GeckoConsole(  105): [JavaScript Error: "NS_ERROR_FAILURE: Denied" {file: "jar:file:///system/b2g/omni.ja!/components/Webapps.js" line: 649}]
E/GeckoConsole(  105): [JavaScript Error: "TypeError: navigator.mozSettings is null" {file: "app://system.gaiamobile.org/js/value_selector/value_selector.js" line: 108}]
E/GeckoConsole(  105): [JavaScript Error: "SecurityError: The operation is insecure." {file: "app://system.gaiamobile.org/shared/js/idletimer.js" line: 101}]
E/GeckoConsole(  105): [JavaScript Error: "TypeError: settings is null" {file: "app://system.gaiamobile.org/js/sleep_menu.js" line: 41}]
E/GeckoConsole(  105): [JavaScript Error: "TypeError: settings is null" {file: "app://system.gaiamobile.org/shared/js/settings_listener.js" line: 34}]
E/GeckoConsole(  105): [JavaScript Error: "SecurityError: The operation is insecure." {file: "app://system.gaiamobile.org/shared/js/idletimer.js" line: 101}]


This might be a regression due to bug 828190.

Comment 1

[Jason Smith [:jsmith]]

Hmm. The latest nightly build from https://pvtbuilds.mozilla.org/pub/mozilla.org/b2g/nightly/mozilla-b2g18-unagi/latest/ works for me. Does that build include this patch?

Comment 2

[Patrick Wang (Chih-Kai Wang) (:kk1fff)]

Attachment: Patch

Getting baseDir doesn't really throw an exception even when coreAppsDir doesn't exist. Check if baseDir exists, and return form that installPreinstalledApp when the base is not there.

Comment 3

[Patrick Wang (Chih-Kai Wang) (:kk1fff)]

(In reply to Jason Smith [:jsmith] from comment #1)
> Hmm. The latest nightly build from
> https://pvtbuilds.mozilla.org/pub/mozilla.org/b2g/nightly/mozilla-b2g18-
> unagi/latest/ works for me. Does that build include this patch?

This changeset is not in current nightly.

Comment 4

[[:fabrice] Fabrice Desré]

Are these eng builds or user ones? I can't reproduce that with a user build.

Comment 5

[[:fabrice] Fabrice Desré]

Comment on attachment 700224 [details] [diff] [review]
Patch

Review of attachment 700224 [details] [diff] [review]:
-----------------------------------------------------------------

::: dom/apps/src/Webapps.jsm
@@ +223,5 @@
>      let app = this.webapps[aId];
>      let baseDir;
>      try {
>        baseDir = FileUtils.getDir("coreAppsDir", ["webapps", aId], false);
> +      if (!baseDir.exists()) return;

nit:
if (!baseDir.exists()) {
  return;
}

Comment 6

[Patrick Wang (Chih-Kai Wang) (:kk1fff)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/a8cad9a3f5f9

Comment 7

[Jonas Sicking (:sicking) No longer reading bugmail consistently]

Being able to start the phone is a preferred user feature.

Comment 8

[Johnny Stenback (:jst)]

baku, can you land this on b2g18?

Comment 9

[Andrea Marchesini [:baku]]

https://hg.mozilla.org/releases/mozilla-b2g18/rev/eeae3d5fb68d

Comment 10

[Johnny Stenback (:jst)]

Landed on inbound and b2g18, marking FIXED.

Comment 11

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/a8cad9a3f5f9

Comment 13

[Jason Smith [:jsmith]]

Well...we're starting up now, so marking as verified.