Closed Bug 828838 Opened 7 years ago Closed 7 years ago

nsCSSRuleProcessor init list out of order

Categories

(Core :: CSS Parsing and Computation, defect)

x86_64
Linux
defect
Not set

Tracking

()

RESOLVED FIXED
mozilla21

People

(Reporter: dholbert, Assigned: dholbert)

References

(Blocks 1 open bug)

Details

Attachments

(1 file)

New build warning:

{
layout/style/nsCSSRuleProcessor.h: In constructor ‘nsCSSRuleProcessor::nsCSSRuleProcessor(const sheet_array_type&, uint8_t, mozilla::dom::Element*)’:

layout/style/nsCSSRuleProcessor.h:183:11: warning: ‘nsCSSRuleProcessor::mSheetType’ will be initialized after [-Wreorder]

layout/style/nsCSSRuleProcessor.h:180:35: warning:   ‘nsRefPtr<mozilla::dom::Element> nsCSSRuleProcessor::mScopeElement’ [-Wreorder]

layout/style/nsCSSRuleProcessor.cpp:1053:1: warning:   when initialized here [-Wreorder]
}

Bug 508725 just added mScopeElement at the wrong spot in the constructor init list.
Attached patch fixSplinter Review
Attachment #700220 - Flags: review?(cam)
Comment on attachment 700220 [details] [diff] [review]
fix

Thanks Daniel.
Attachment #700220 - Flags: review?(cam) → review+
https://hg.mozilla.org/mozilla-central/rev/1bc7abeadfe9
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla21
You need to log in before you can comment on or make changes to this bug.