Closed
Bug 828838
Opened 13 years ago
Closed 13 years ago
nsCSSRuleProcessor init list out of order
Categories
(Core :: CSS Parsing and Computation, defect)
Tracking
()
RESOLVED
FIXED
mozilla21
People
(Reporter: dholbert, Assigned: dholbert)
References
(Blocks 1 open bug)
Details
Attachments
(1 file)
|
1.08 KB,
patch
|
heycam
:
review+
|
Details | Diff | Splinter Review |
New build warning:
{
layout/style/nsCSSRuleProcessor.h: In constructor ‘nsCSSRuleProcessor::nsCSSRuleProcessor(const sheet_array_type&, uint8_t, mozilla::dom::Element*)’:
layout/style/nsCSSRuleProcessor.h:183:11: warning: ‘nsCSSRuleProcessor::mSheetType’ will be initialized after [-Wreorder]
layout/style/nsCSSRuleProcessor.h:180:35: warning: ‘nsRefPtr<mozilla::dom::Element> nsCSSRuleProcessor::mScopeElement’ [-Wreorder]
layout/style/nsCSSRuleProcessor.cpp:1053:1: warning: when initialized here [-Wreorder]
}
Bug 508725 just added mScopeElement at the wrong spot in the constructor init list.
|
Assignee | |
Comment 1•13 years ago
|
||
Attachment #700220 -
Flags: review?(cam)
|
|
Assignee | |
Comment 2•13 years ago
|
||
MXR link to show that the new order is correct:
https://mxr.mozilla.org/mozilla-central/source/layout/style/nsCSSRuleProcessor.h?mark=180-183#180
|
||
Comment 3•13 years ago
|
||
Comment on attachment 700220 [details] [diff] [review]
fix
Thanks Daniel.
Attachment #700220 -
Flags: review?(cam) → review+
|
|
Assignee | |
Comment 4•13 years ago
|
||
Status: NEW → ASSIGNED
|
||
Comment 5•13 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla21
You need to log in
before you can comment on or make changes to this bug.
Description
•