Remove feedback app from release builds

VERIFIED FIXED

Status

Firefox OS
Gaia
VERIFIED FIXED
5 years ago
5 years ago

People

(Reporter: jsmith, Assigned: vingtetun)

Tracking

unspecified
ARM
Gonk (Firefox OS)
Dependency tree / graph

Firefox Tracking Flags

(blocking-b2g:tef+, blocking-basecamp:-, b2g18 fixed, b2g18-v1.0.0 fixed)

Details

(Whiteboard: [Triaged:1/17])

Attachments

(1 attachment)

(Reporter)

Description

5 years ago
The feedback app should only be part of dogfooding builds. Are we making sure production release builds don't contain this app?

The unagi builds being generated right now include this app by default.
(Reporter)

Updated

5 years ago
blocking-basecamp: --- → ?
Lukkas, are we still getting feedback from the Feedback app? We (triagers) know we need to pull this from final release, but are unsure whether we should do so now, or wait, if valuable feedback is still coming through.
Flags: needinfo?(lsblakk)
blocking-b2g: --- → tef+
blocking-basecamp: ? → -
Assignee: nobody → 21
We'll need this in beta builds and then, correctly, not in release builds.  Including some release engineering folks to determine if we can set this up.
Flags: needinfo?(lsblakk) → needinfo?(catlee)

Updated

5 years ago
Whiteboard: [triaged:1/15]
Whiteboard: [triaged:1/15]
Whiteboard: [Triaged:1/17]
What flags/bit/env vars need to be flipped to remove or include the Feedback app in builds?
If there's a make/mozconfig or other variable that can be set to disable this, then we can flip that setting. If there's no such control, we should probably add it now. This won't be the first time we need to remove the feedback app!
Flags: needinfo?(catlee) → needinfo?(jhford)
Created attachment 704828 [details] [diff] [review]
Patch

Let's add a |make dogfood|
Attachment #704828 - Flags: review?(poirot.alex)
Comment on attachment 704828 [details] [diff] [review]
Patch

Looks good, seems like a good approach in order to eventually reintroduce marketplace-dev in trunk.
Attachment #704828 - Flags: review?(poirot.alex) → review+

Comment 8

5 years ago
Smoketest regression
Unagi build 2013-01-23-07-02-02, Kernel Dec 5

verified fixed - Feedback app is no longer displayed
Status: RESOLVED → VERIFIED
Flags: needinfo?(jhford)
So RelEng should now set DOGFOOD=1 when calling ./build.sh for the builds that end up on nightly & beta channels  ?
Or perhaps add 'dogfood' as an argument to the build.sh call.
Blocks: 833945
status-b2g18: --- → fixed
Landed on mozilla-b2g18/gaia master prior to the 1/25 branching to mozilla-b2g18_v1_0_0/v1.0.0, updating status-b2g-v1.0.0 to fixed.
status-b2g18-v1.0.0: --- → fixed
Depends on: 837559
You need to log in before you can comment on or make changes to this bug.