828908 - [Settings] Hints should not be treated as list items

Status: VERIFIED FIXED

(Firefox OS Graveyard :: Gaia::Settings, defect)

Description

[Sergi]

Attachment: Correct use of Hints :: Screenshot

Hints are used to provide further info to the user in cases where the action to perform needs further clarification. Taking this into account they should not be treated as "independent" list items and they have to be always displayed underneath the list item they pertain to, without using any divider between them.

Comment 1

[Sam Joch [:samjoch]]

Attachment: branch patch

Comment 2

[Peter La]

Just loaded this and it looks as intended (same as the attachment 'Correct use of Hints :: Screenshot').

Comment 3

[Sam Joch [:samjoch]]

landed in uxbranch: https://github.com/gordonbrander/gaia/commit/42ae93a5cc9787e61801f84bfeaedc0fb402ccc0

Comment 4

[Sam Joch [:samjoch]]

https://github.com/mozilla-b2g/gaia/commit/25d9e53380db967d76223c5f1e1940ed907ed447

Comment 5

[Naoki Hirata :nhirata (please use needinfo instead of cc)]

verfied on master, 
Master build : 2013-03-26-07-02-04
"mozilla-central" revision="28b048ffb7a7"
"integration/gaia-central" revision="44f6a17f24d4"
"gecko.git"revision="a800f14ea7022a78966f7fe14a9b0d11c569b151"
"gaia.git" revision="ace1eb32a313da1232bbdf9cff2581a4b036356d"

Not on v1 train.  filing bug on the overlapping text.

Comment 6

[Stephany Wilkes]

Comment on attachment 707579 [details]
branch patch

Is this ready to raise to approval? with user value and risk in the comments? Our goal is to wrap up all Yedo and VxD changes by April 5th.

Comment 7

[Sam Joch [:samjoch]]

Comment on attachment 707579 [details]
branch patch

Master commit hash is 6c6cb69

NOTE: Please see https://wiki.mozilla.org/Release_Management/B2G_Landing to better understand the B2G approval process and landings.

[Approval Request Comment]
Bug caused by (feature/regressing bug #): -
User impact if declined: -
Testing completed: Yes see #c5
Risk to taking this patch (and alternatives if risky): Only CSS changes and HTML tags.
String or UUID changes made by this patch: -

Comment 8

[Vivien Nicolas (:vingtetun) (:21) - (NOT reading bugmails, needinfo? please)]

Comment on attachment 707579 [details]
branch patch

This comes from the UX branch process where QA has already checked that it works. a=me.

Comment 9

[John Ford [:jhford] CET/CEST Berlin Time]

I was not able to uplift this bug to v1-train.  If this bug has dependencies which are not marked in this bug, please comment on this bug.  If this bug depends on patches that aren't approved for v1-train, we need to re-evaluate the approval.  Otherwise, if this is just a merge conflict, you might be able to resolve it with:

  git checkout v1-train
  git cherry-pick -x -m1 25d9e53380db967d76223c5f1e1940ed907ed447
  <RESOLVE MERGE CONFLICTS>
  git commit

Comment 10

[Eric Pang [:epang] UX]

(In reply to John Ford [:jhford] from comment #9)
> I was not able to uplift this bug to v1-train.  If this bug has dependencies
> which are not marked in this bug, please comment on this bug.  If this bug
> depends on patches that aren't approved for v1-train, we need to re-evaluate
> the approval.  Otherwise, if this is just a merge conflict, you might be
> able to resolve it with:
> 
>   git checkout v1-train
>   git cherry-pick -x -m1 25d9e53380db967d76223c5f1e1940ed907ed447
>   <RESOLVE MERGE CONFLICTS>
>   git commit

Sam, can you please look into this? Thanks!

Comment 11

[Sam Joch [:samjoch]]

Be careful that master commit hash for this bug is 6c6cb69 (ie. #c7)

Comment 12

[John Ford [:jhford] CET/CEST Berlin Time]

v1-train: 6992012