828957 - Port |Bug 824330 - Enable services in xulrunner and don't build under services/ when building against a libxul SDK| to SeaMonkey

Status: RESOLVED FIXED

(SeaMonkey :: Build Config, defect)

Description

[Frank Wein [:mcsmurf]]

The patch in Bug 824330 should be ported to SeaMonkey/comm-central as otherwise (py)make will try to package mozilla/services/ twice (according to Neil).

Comment 1

[Frank Wein [:mcsmurf]]

Attachment: Patch

Comment 2

[Frank Wein [:mcsmurf]]

Also the build will break locally when using pymake (looks like):
make.py[5]: Entering directory 'c:\mozilla\tree-hg\objdirs\seamonkey-objdir-debu
g-tests\mozilla'
Target 'services/Makefile' has multiple rules with commands.
[...]
e testing/mozbase/Makefile media/webrtc/signaling/test/Makefile media/mtransport
/test/Makefile' failed, return code 2
c:\mozilla\tree-hg\comm-central\mozilla\config\rules.mk:608:0: command 'c:/mozil
la-build/python/python.exe C:/mozilla/tree-hg/comm-central/mozilla/build/pymake/
pymake/../make.py export_tier_platform' failed, return code 2

Comment 3

[Frank Wein [:mcsmurf]]

Comment on attachment 700628 [details] [diff] [review]
Patch

Neil: See Attachment 698016 [details] [diff] for the Firefox patch, this patch ports the Firefox change to SeaMonkey. You also mentioned this on IRC yesterday afaik.

Comment 4

[Frank Wein [:mcsmurf]]

Pushed: https://hg.mozilla.org/comm-central/rev/bc4fa652cdf7

Comment 5

[Frank Wein [:mcsmurf]]

Comment on attachment 700628 [details] [diff] [review]
Patch

[Approval Request Comment]
Regression caused by (bug #): -
User impact if declined: Some users may not be able to compile SeaMonkey; needed for comm-aurora as the underlying bug on mozilla-central landed before the uplift
Testing completed (on m-c, etc.): Works on comm-central, Firefox build.mk file was changed in the same way (this patch ports the change from Firefox to SeaMonkey)
Risk to taking this patch (and alternatives if risky): build change only, no risk
String changes made by this patch: -

Comment 6

[Philip Chee]

Comment on attachment 700628 [details] [diff] [review]
Patch

a=me for comm-aurora

Comment 7

[Frank Wein [:mcsmurf]]

Pushed: https://hg.mozilla.org/releases/comm-aurora/rev/6eafbba68d75