829006 - Setting proxies via applyFilter() (nsIProtocolProxyFilter) does not work anymore when WPAD mode is selected

Status: RESOLVED FIXED

(Core :: Networking: HTTP, defect)

Description

[Georg Koppen]

Attachment: applyfilter.xpi

User Agent: Mozilla/5.0 (Windows NT 6.1; rv:17.0) Gecko/20100101 Firefox/17.0

Steps to reproduce:

I installed the attached minimal test-case which sets a non-existing proxy (127.0.0.1:9999) via applyFilter() in Firefox 18 and set the Firefox proxy settings to "Auto-detect proxy settings for this network".



Actual results:

The proxy in applyFilter() is ignored.


Expected results:

No connections should have been made as the proxy returned via applyFilter() is not existing.

Seems we missed that corner case in 795905.

Comment 1

[Georg Koppen]

Still an issue in Firefox 18.0.1. Blocking 769764 as this is likely caused by it (as 795905 has been).

Comment 2

[Patrick McManus [:mcmanus]]

Attachment: patch 0

the bug occurs when the pac thread is returning NOT_AVAILABLE (in the case of failed WPAD discovery in this case) we are going to go direct but instead we return the error to the HTTP (or other protocol stack) and let it do the mapping locally.

instead, lets make the -> direct map in the protocol proxy service and apply the filters and return OK to the protocol stack.

Comment 3

[Patrick McManus [:mcmanus]]

Comment on attachment 705969 [details] [diff] [review]
patch 0

biesi r? timeout resched

Comment 4

[Patrick McManus [:mcmanus]]

remote:   https://hg.mozilla.org/integration/mozilla-inbound/rev/7d39a9c9cb7f

Comment 5

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/7d39a9c9cb7f