Closed
Bug 829028
Opened 13 years ago
Closed 12 years ago
Debugger should not interrupt the client twice at the same location
Categories
(DevTools :: Debugger, defect, P3)
Tracking
(Not tracked)
RESOLVED
FIXED
Firefox 25
People
(Reporter: Honza, Assigned: past)
Details
(Whiteboard: [firebug-p2])
Attachments
(1 file, 1 obsolete file)
11.32 KB,
patch
|
rcampbell
:
review+
|
Details | Diff | Splinter Review |
Imagine following scenario:
1. var a = 10;
*2. var b = 20; // this line has a breakpoint
3. var c = 30;
1) The script execution starts at line #1
2) The user steps-over and the next interrupt happens at line #2
3) The user steps-over and the next interrupt happens at line #2 again because of the breakpoint.
The debugger (server side) should be smart enough to recognize that the second interrupt (at the line #2) is not necessary (it's the same debugging location as where the debugger already is).
Honza
Reporter | ||
Updated•13 years ago
|
Whiteboard: [firebug-p2]
Assignee | ||
Comment 1•13 years ago
|
||
I think BA_hit should just continue instead of pausing, if onStep or onEnetrFrame hooks are set on the frame/debugger. Maybe only onStep, since stepping over a function could trigger breakpoints inside that function and perhaps pausing there would be expected?
Priority: -- → P3
Assignee | ||
Comment 2•12 years ago
|
||
This works but needs a test.
Assignee | ||
Updated•12 years ago
|
Assignee: nobody → past
Assignee | ||
Updated•12 years ago
|
Status: NEW → ASSIGNED
Assignee | ||
Comment 3•12 years ago
|
||
Added tests for both cases described in comment 1.
Attachment #776374 -
Flags: review?(rcampbell)
Assignee | ||
Updated•12 years ago
|
Attachment #775352 -
Attachment is obsolete: true
Comment 4•12 years ago
|
||
Comment on attachment 776374 [details] [diff] [review]
Don't pause twice on a breakpoint or debugger statement while stepping v2
Review of attachment 776374 [details] [diff] [review]:
-----------------------------------------------------------------
::: toolkit/devtools/server/tests/unit/test_breakpoint-13.js
@@ +91,5 @@
> + });
> + // Step into the next line with the function call.
> + gThreadClient.stepIn();
> + });
> + });
pretty.
Attachment #776374 -
Flags: review?(rcampbell) → review+
Assignee | ||
Comment 5•12 years ago
|
||
Whiteboard: [firebug-p2] → [firebug-p2][fixed-in-fx-team]
Comment 6•12 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Whiteboard: [firebug-p2][fixed-in-fx-team] → [firebug-p2]
Target Milestone: --- → Firefox 25
Updated•7 years ago
|
Product: Firefox → DevTools
You need to log in
before you can comment on or make changes to this bug.
Description
•