Imagine following scenario: 1. var a = 10; *2. var b = 20; // this line has a breakpoint 3. var c = 30; 1) The script execution starts at line #1 2) The user steps-over and the next interrupt happens at line #2 3) The user steps-over and the next interrupt happens at line #2 again because of the breakpoint. The debugger (server side) should be smart enough to recognize that the second interrupt (at the line #2) is not necessary (it's the same debugging location as where the debugger already is). Honza
I think BA_hit should just continue instead of pausing, if onStep or onEnetrFrame hooks are set on the frame/debugger. Maybe only onStep, since stepping over a function could trigger breakpoints inside that function and perhaps pausing there would be expected?
Created attachment 775352 [details] [diff] [review] Don't pause twice on a breakpoint or debugger statement while stepping This works but needs a test.
Created attachment 776374 [details] [diff] [review] Don't pause twice on a breakpoint or debugger statement while stepping v2 Added tests for both cases described in comment 1.
Comment on attachment 776374 [details] [diff] [review] Don't pause twice on a breakpoint or debugger statement while stepping v2 Review of attachment 776374 [details] [diff] [review]: ----------------------------------------------------------------- ::: toolkit/devtools/server/tests/unit/test_breakpoint-13.js @@ +91,5 @@ > + }); > + // Step into the next line with the function call. > + gThreadClient.stepIn(); > + }); > + }); pretty.
https://hg.mozilla.org/integration/fx-team/rev/5be325efcdcf
https://hg.mozilla.org/mozilla-central/rev/5be325efcdcf
or
