829063 - Toolbox style improvements

Status: RESOLVED FIXED

(DevTools :: Framework, defect)

Comment 1

[Paul Rouget [:paul]]

Attachment: v0.1

This patch correctly includes the noise (missing from jar.mn), implement the flat toolbar, and implement the correct design for the sidebar.

Not tested on Windows yet.

Comment 2

[Girish Sharma [:Optimizer]]

Attachment: screenshot of patch on windows

Looks awesome with an added advantage of having style upgrade for 2 of my add-ons automatically for free :P

Although the sidebar's selected tab is missing some style ...

Comment 3

[Paul Rouget [:paul]]

Attachment: v1

windows aero preprocessing added

Comment 4

[Girish Sharma [:Optimizer]]

Attachment: screenshot of patch v1

This is perfect. sidebar tab issue fixed now.

Comment 5

[Heather Arthur [:harth]]

Comment on attachment 700477 [details] [diff] [review]
v1

Review of attachment 700477 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good. One small visual issue on Mac - the inspector sidebar's toolbar looks to be 1px higher than the breadcrumb's toolbar: http://i.imgur.com/AEU5w.png.

::: browser/themes/pinstripe/devtools/splitview.css
@@ +68,5 @@
>  
>  /* Toolbars */
>  
>  .devtools-toolbar {
>    height: 26px;

jw, is this obsolete now?

Comment 6

[Paul Rouget [:paul]]

(In reply to Heather Arthur [:harth] from comment #5)
> Looks good. One small visual issue on Mac - the inspector sidebar's toolbar
> looks to be 1px higher than the breadcrumb's toolbar:
> http://i.imgur.com/AEU5w.png.

That's bad :( That means I'm missing something in my padding computation.
I don't have this problem on my Mac.

> ::: browser/themes/pinstripe/devtools/splitview.css
> @@ +68,5 @@
> >  
> >  /* Toolbars */
> >  
> >  .devtools-toolbar {
> >    height: 26px;
> 
> jw, is this obsolete now?

It's in splitview.css. I don't want to touch this yet.

Comment 7

[Paul Rouget [:paul]]

(In reply to Paul Rouget [:paul] from comment #6)
> (In reply to Heather Arthur [:harth] from comment #5)
> > Looks good. One small visual issue on Mac - the inspector sidebar's toolbar
> > looks to be 1px higher than the breadcrumb's toolbar:
> > http://i.imgur.com/AEU5w.png.
> 
> That's bad :( That means I'm missing something in my padding computation.
> I don't have this problem on my Mac.

I will fix that later: bug 830684.

Comment 8

[Paul Rouget [:paul]]

Comment on attachment 700477 [details] [diff] [review]
v1

[Approval Request Comment]
Bug caused by (feature/regressing bug #): new feature (toolbox)
User impact if declined: the inspector sidebar looks unfinished
Testing completed (on m-c, etc.): locally
Risk to taking this patch (and alternatives if risky): low (only CSS improvements)
String or UUID changes made by this patch: no

Comment 9

[Panos Astithas (he/him) [:past] (please ni?)]

https://hg.mozilla.org/integration/fx-team/rev/4ba4e660de74

Comment 10

[Panos Astithas (he/him) [:past] (please ni?)]

https://hg.mozilla.org/mozilla-central/rev/4ba4e660de74

Comment 11

[Paul Rouget [:paul]]

https://hg.mozilla.org/releases/mozilla-aurora/rev/ed97311aadce