Closed
Bug 829063
Opened 11 years ago
Closed 11 years ago
Toolbox style improvements
Categories
(DevTools :: Framework, defect)
Tracking
(firefox20 fixed)
RESOLVED
FIXED
Firefox 21
Tracking | Status | |
---|---|---|
firefox20 | --- | fixed |
People
(Reporter: paul, Assigned: paul)
Details
Attachments
(2 files, 2 obsolete files)
32.43 KB,
patch
|
harth
:
review+
bajaj
:
approval-mozilla-aurora+
|
Details | Diff | Splinter Review |
119.09 KB,
image/png
|
Details |
No description provided.
Assignee | ||
Comment 1•11 years ago
|
||
This patch correctly includes the noise (missing from jar.mn), implement the flat toolbar, and implement the correct design for the sidebar. Not tested on Windows yet.
Comment 2•11 years ago
|
||
Looks awesome with an added advantage of having style upgrade for 2 of my add-ons automatically for free :P Although the sidebar's selected tab is missing some style ...
Assignee | ||
Comment 3•11 years ago
|
||
windows aero preprocessing added
Assignee | ||
Updated•11 years ago
|
Attachment #700477 -
Flags: review?(fayearthur)
Comment 4•11 years ago
|
||
This is perfect. sidebar tab issue fixed now.
Attachment #700464 -
Attachment is obsolete: true
Comment 5•11 years ago
|
||
Comment on attachment 700477 [details] [diff] [review] v1 Review of attachment 700477 [details] [diff] [review]: ----------------------------------------------------------------- Looks good. One small visual issue on Mac - the inspector sidebar's toolbar looks to be 1px higher than the breadcrumb's toolbar: http://i.imgur.com/AEU5w.png. ::: browser/themes/pinstripe/devtools/splitview.css @@ +68,5 @@ > > /* Toolbars */ > > .devtools-toolbar { > height: 26px; jw, is this obsolete now?
Attachment #700477 -
Flags: review?(fayearthur) → review+
Assignee | ||
Comment 6•11 years ago
|
||
(In reply to Heather Arthur [:harth] from comment #5) > Looks good. One small visual issue on Mac - the inspector sidebar's toolbar > looks to be 1px higher than the breadcrumb's toolbar: > http://i.imgur.com/AEU5w.png. That's bad :( That means I'm missing something in my padding computation. I don't have this problem on my Mac. > ::: browser/themes/pinstripe/devtools/splitview.css > @@ +68,5 @@ > > > > /* Toolbars */ > > > > .devtools-toolbar { > > height: 26px; > > jw, is this obsolete now? It's in splitview.css. I don't want to touch this yet.
Assignee | ||
Comment 7•11 years ago
|
||
(In reply to Paul Rouget [:paul] from comment #6) > (In reply to Heather Arthur [:harth] from comment #5) > > Looks good. One small visual issue on Mac - the inspector sidebar's toolbar > > looks to be 1px higher than the breadcrumb's toolbar: > > http://i.imgur.com/AEU5w.png. > > That's bad :( That means I'm missing something in my padding computation. > I don't have this problem on my Mac. I will fix that later: bug 830684.
Whiteboard: [land-in-fx-team]
Assignee | ||
Comment 8•11 years ago
|
||
Comment on attachment 700477 [details] [diff] [review] v1 [Approval Request Comment] Bug caused by (feature/regressing bug #): new feature (toolbox) User impact if declined: the inspector sidebar looks unfinished Testing completed (on m-c, etc.): locally Risk to taking this patch (and alternatives if risky): low (only CSS improvements) String or UUID changes made by this patch: no
Attachment #700477 -
Flags: approval-mozilla-aurora?
Comment 9•11 years ago
|
||
https://hg.mozilla.org/integration/fx-team/rev/4ba4e660de74
Whiteboard: [land-in-fx-team] → [fixed-in-fx-team]
Comment 10•11 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/4ba4e660de74
Status: ASSIGNED → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Whiteboard: [fixed-in-fx-team]
Target Milestone: --- → Firefox 21
Updated•11 years ago
|
Attachment #700477 -
Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
Assignee | ||
Updated•11 years ago
|
Whiteboard: [land-in-aurora]
Assignee | ||
Comment 11•11 years ago
|
||
https://hg.mozilla.org/releases/mozilla-aurora/rev/ed97311aadce
status-firefox20:
--- → fixed
Whiteboard: [land-in-aurora]
Updated•6 years ago
|
Product: Firefox → DevTools
You need to log in
before you can comment on or make changes to this bug.
Description
•