829112 - Fix "comparison between signed and unsigned integer expressions" warnings in nsStyleSet.cpp

Status: RESOLVED FIXED

(Core :: CSS Parsing and Computation, defect)

Description

[Daniel Holbert [:dholbert]]

nsStyleSet.cpp has a bunch of build warnings from using a signed variable as a loop-iterator, which we compare to an unsigned 'count' variable in the loop condition.

{
layout/style/nsStyleSet.cpp: In member function ‘nsresult nsStyleSet::GatherRuleProcessors(nsStyleSet::sheetType)’:

layout/style/nsStyleSet.cpp:298:62: warning: comparison between signed and unsigned integer expressions [-Wsign-compare]

layout/style/nsStyleSet.cpp:335:31: warning: comparison between signed and unsigned integer expressions [-Wsign-compare]

layout/style/nsStyleSet.cpp: In member function ‘void nsStyleSet::FileRules(nsIStyleRuleProcessor::EnumFunc, RuleProcessorData*, mozilla::dom::Element*, nsRuleWalker*)’:

layout/style/nsStyleSet.cpp:964:66: warning: comparison between signed and unsigned integer expressions [-Wsign-compare]

layout/style/nsStyleSet.cpp: In member function ‘void nsStyleSet::WalkRuleProcessors(nsIStyleRuleProcessor::EnumFunc, ElementDependentRuleProcessorData*, bool)’:

layout/style/nsStyleSet.cpp:1113:68: warning: comparison between signed and unsigned integer expressions [-Wsign-compare]
}

Comment 1

[Daniel Holbert [:dholbert]]

Attachment: fix v1

This makes nsStyleSet.cpp compile w/ no build warnings at all, FWIW. (woot)

Comment 2

[Boris Zbarsky [:bzbarsky]]

Comment on attachment 700520 [details] [diff] [review]
fix v1

r=me

Comment 3

[Daniel Holbert [:dholbert]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/5b042b636671

Comment 4

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/5b042b636671

Comment 5

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/5b042b636671

Comment 6

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/5b042b636671