Closed Bug 829114 Opened 11 years ago Closed 7 years ago

Remove backwards compatibility hack

Categories

(Core :: Gecko Profiler, defect)

x86
macOS
defect
Not set
normal

Tracking

()

RESOLVED DUPLICATE of bug 1330833

People

(Reporter: espindola, Assigned: espindola)

Details

Attachments

(1 file)

Attached patch patchSplinter Review
This can only be pushed when the addon has been updated.

I am building firefox with it to make sure the current addon master still works.
Attachment #700519 - Flags: review?(bgirard)
Comment on attachment 700519 [details] [diff] [review]
patch

Review of attachment 700519 [details] [diff] [review]:
-----------------------------------------------------------------

r+ but please wait until an update to deploy to AMO
Attachment #700519 - Flags: review?(bgirard) → review+
needinfo=self for when to the update is deployed to AMO
Flags: needinfo?(bgirard)
The build finished fine and the addon works. This can be committed when the addon is deployed.
Has the now addon been removed from AMO? I don't see it in

https://addons.mozilla.org/en-us/firefox/addon/gecko-profiler/versions/

anymore.
Flags: needinfo?(bgirard)
This is going to be part of my patch in bug 1330833. I need the modification to avoid a problem during tests with a module with no PDB file.
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
Resolution: --- → DUPLICATE
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: